Fix parent commit - Githubissues

whilefoo commented 2 months ago

Resolves #275

Changes:

If parent commit of the first commit of the PR doesn't exist, it uses the first commit's SHA
When fetching excluded files added the ref parameter - this means that if the PR base branch is development it will check .gitattributes in development
Fixed Web UI payload to fetch the real payload from Github API instead of faking it

QA is me running locally on the same issue that had this problem and this is the result:

[ 601.41 WXDAI ]
@zugdev
Contributions Overview
View Contribution Count Reward
Issue Task 1 600
Issue Comment 1 1.41
Conversation Incentives
Comment Formatting Relevance Priority Reward
Can I refactor it entirely?
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
1
3
1.41
[ 600 WXDAI ]
@rndquu
Contributions Overview
View Contribution Count Reward
Review Base Review for #1 1 25
Review Code Review 4 821.55
Issue Specification 1 87.63
Issue Comment 5 102.54
Review Comment 7 82.95
Review Details for #1
Changes Priority Reward
+10435 -2243 3 380.34
+16 -253 3 8.07
+6 -1 3 0.21
+3349 -11082 3 432.93
Conversation Incentives
Comment Formatting Relevance Priority Reward
Right now this repository is a 2-step setup wizard:- Step 1: c…
23.61
content:
  content:
    p:
      score: 0
      elementCount: 8
    ul:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 6
    ol:
      score: 1
      elementCount: 1
    a:
      score: 5
      elementCount: 3
  result: 20
regex:
  wordCount: 68
  wordValue: 0.1
  result: 3.61
1
3
87.63
Yes
0.2
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 1
  wordValue: 0.2
  result: 0.2
1
3
0.78
https://github.com/ubiquity-os/.ubiquity-os/blob/63bd7e7747c9226…
7.11
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 16
  wordValue: 0.2
  result: 2.11
1
3
27.57
Settings are taken from [this](https://github.com/ubiquity/.ubiq…
8.09
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 25
  wordValue: 0.2
  result: 3.09
1
3
31.47
@gentlementlegen Help, I don't fully understand what's wrong her…
9.6
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 40
  wordValue: 0.2
  result: 4.6
1
3
37.41
Because we have a convention of "many small web UIs".
1.42
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 10
  wordValue: 0.2
  result: 1.42
1
3
5.31
Overall works fine.Pls:1. Fix contract address in the commen…
8.44
content:
  content:
    p:
      score: 0
      elementCount: 4
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 7
regex:
  wordCount: 23
  wordValue: 0.1
  result: 1.44
1
3
32.43
Somehow when mainnet is selected the UI shows that UUSD token is…
6.95
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 33
  wordValue: 0.1
  result: 1.95
1
3
26.4
Works fine
0.18
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0.1
  result: 0.18
1
3
0.69
Works fine
0.18
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0.1
  result: 0.18
1
3
0.69
Should be `0xb6919Ef2ee4aFC163BC954C5678e2BB570c2D103`
0.18
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0.1
  result: 0.18
1
3
0.69
Should be `0xb6919Ef2ee4aFC163BC954C5678e2BB570c2D103 ` …
0.32
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0.1
  result: 0.32
1
3
1.26
Somehow [llamarpc](https://github.com/ubiquity/permit2-allowance…
5.59
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 8
  wordValue: 0.1
  result: 0.59
1
3
20.79
[ 56.67 WXDAI ]
@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 4 37.41
Review Comment 1 19.26
Conversation Incentives
Comment Formatting Relevance Priority Reward
I think we should leave everything in separate codebases as much…
1.11
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 17
  wordValue: 0.1
  result: 1.11
1
3
4.17
@rndquu Are the settings intentional on this repo?
0.59
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 8
  wordValue: 0.1
  result: 0.59
1
3
2.28
An observation was made: why did we split off the allowances to …
6
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 15
  wordValue: 0.1
  result: 1
1
3
23.13
Yes and I suppose that the permit allowance only needs to handle…
2.05
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 35
  wordValue: 0.1
  result: 2.05
1
3
7.83
https://github.com/ubiquity/uusd.ubq.fi/pull/13#issuecomment-263…
5
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 0
  wordValue: 0.1
  result: 0
1
3
19.26
[ 11.37 WXDAI ]
@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Comment 1 11.37
Conversation Incentives
Comment Formatting Relevance Priority Reward
@rndquu It seems to be an issue with the ReviewIncentivizer modu…
2.97
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 54
  wordValue: 0.1
  result: 2.97
1
3
11.37
[ 600 WXDAI ]
@whilefoo
Contributions Overview
View Contribution Count Reward
Review Base Review for #1 1 25
Review Code Review 4 811.59
Review Comment 13 5.1
Review Details for #1
Changes Priority Reward
+10375 -2292 3 380.01
+3237 -11106 3 430.29
+28 -15 3 1.29
+0 -0 3 0
Conversation Incentives
Comment Formatting Relevance Priority Reward
Please make sure the CI passes
0.46
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 6
  wordValue: 0.1
  result: 0.46
1
3
0.45
Knip still fails
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
1
3
0.24
shouldn't `key` be number?
0.32
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0.1
  result: 0.32
1
3
0.3
```suggestionsuccessMessageElement.innerHTML =…
0
content:
  content: {}
  result: 0
regex:
  wordCount: 0
  wordValue: 0.1
  result: 0
1
3
0
you can use `replaceChildren()` to avoid using `""&#…
0.46
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 6
  wordValue: 0.1
  result: 0.46
1
3
0.42
```suggestionif (error instanceof Error &&…
0.32
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0.1
  result: 0.32
1
3
0.3
this should be `permit2-allowance.ubq.fi` now
0.32
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0.1
  result: 0.32
1
3
0.3
Switch to Bun so we are using the same package manager across al…
1
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 15
  wordValue: 0.1
  result: 1
1
3
0.96
change to Bun
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
1
3
0.24
change to Bun
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
1
3
0.24
Was this because of a type error because the callback is not exp…
1.17
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 18
  wordValue: 0.1
  result: 1.17
1
3
1.11
Also because of type error?
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
1
3
0.36
yeah maybe
0.18
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0.1
  result: 0.18
1
3
0.18

View	Contribution	Count	Reward
Issue	Task	1	600
Issue	Comment	1	1.41

Comment	Formatting	Relevance	Priority	Reward
Can I refactor it entirely?	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	1	3	1.41

View	Contribution	Count	Reward
Review	Base Review for #1	1	25
Review	Code Review	4	821.55
Issue	Specification	1	87.63
Issue	Comment	5	102.54
Review	Comment	7	82.95

Changes	Priority	Reward
+10435 -2243	3	380.34
+16 -253	3	8.07
+6 -1	3	0.21
+3349 -11082	3	432.93

Comment	Formatting	Relevance	Priority	Reward
Right now this repository is a 2-step setup wizard:- Step 1: c…	23.61 content: content: p: score: 0 elementCount: 8 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 6 ol: score: 1 elementCount: 1 a: score: 5 elementCount: 3 result: 20 regex: wordCount: 68 wordValue: 0.1 result: 3.61	1	3	87.63
Yes	0.2 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 1 wordValue: 0.2 result: 0.2	1	3	0.78
https://github.com/ubiquity-os/.ubiquity-os/blob/63bd7e7747c9226…	7.11 content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 16 wordValue: 0.2 result: 2.11	1	3	27.57
Settings are taken from [this](https://github.com/ubiquity/.ubiq…	8.09 content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 25 wordValue: 0.2 result: 3.09	1	3	31.47
@gentlementlegen Help, I don't fully understand what's wrong her…	9.6 content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 40 wordValue: 0.2 result: 4.6	1	3	37.41
Because we have a convention of "many small web UIs".	1.42 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0.2 result: 1.42	1	3	5.31
Overall works fine.Pls:1. Fix contract address in the commen…	8.44 content: content: p: score: 0 elementCount: 4 ol: score: 1 elementCount: 1 li: score: 0.5 elementCount: 2 a: score: 5 elementCount: 1 result: 7 regex: wordCount: 23 wordValue: 0.1 result: 1.44	1	3	32.43
Somehow when mainnet is selected the UI shows that UUSD token is…	6.95 content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 33 wordValue: 0.1 result: 1.95	1	3	26.4
Works fine	0.18 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0.1 result: 0.18	1	3	0.69
Works fine	0.18 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0.1 result: 0.18	1	3	0.69
Should be `0xb6919Ef2ee4aFC163BC954C5678e2BB570c2D103`	0.18 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0.1 result: 0.18	1	3	0.69
Should be `0xb6919Ef2ee4aFC163BC954C5678e2BB570c2D103 ` …	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	1	3	1.26
Somehow [llamarpc](https://github.com/ubiquity/permit2-allowance…	5.59 content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 8 wordValue: 0.1 result: 0.59	1	3	20.79

View	Contribution	Count	Reward
Issue	Comment	4	37.41
Review	Comment	1	19.26

Comment	Formatting	Relevance	Priority	Reward
I think we should leave everything in separate codebases as much…	1.11 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11	1	3	4.17
@rndquu Are the settings intentional on this repo?	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	1	3	2.28
An observation was made: why did we split off the allowances to …	6 content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 15 wordValue: 0.1 result: 1	1	3	23.13
Yes and I suppose that the permit allowance only needs to handle…	2.05 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 35 wordValue: 0.1 result: 2.05	1	3	7.83
https://github.com/ubiquity/uusd.ubq.fi/pull/13#issuecomment-263…	5 content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 0 wordValue: 0.1 result: 0	1	3	19.26

View	Contribution	Count	Reward
Issue	Comment	1	11.37

Comment	Formatting	Relevance	Priority	Reward
@rndquu It seems to be an issue with the ReviewIncentivizer modu…	2.97 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 54 wordValue: 0.1 result: 2.97	1	3	11.37

View	Contribution	Count	Reward
Review	Base Review for #1	1	25
Review	Code Review	4	811.59
Review	Comment	13	5.1

Changes	Priority	Reward
+10375 -2292	3	380.01
+3237 -11106	3	430.29
+28 -15	3	1.29
+0 -0	3	0

Comment	Formatting	Relevance	Priority	Reward
Please make sure the CI passes	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	1	3	0.45
Knip still fails	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	1	3	0.24
shouldn't `key` be number?	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	1	3	0.3
```suggestionsuccessMessageElement.innerHTML =…	0 content: content: {} result: 0 regex: wordCount: 0 wordValue: 0.1 result: 0	1	3	0
you can use `replaceChildren()` to avoid using `""&#…	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	1	3	0.42
```suggestionif (error instanceof Error &&…	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	1	3	0.3
this should be `permit2-allowance.ubq.fi` now	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	1	3	0.3
Switch to Bun so we are using the same package manager across al…	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	1	3	0.96
change to Bun	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	1	3	0.24
change to Bun	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	1	3	0.24
Was this because of a type error because the callback is not exp…	1.17 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0.1 result: 1.17	1	3	1.11
Also because of type error?	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	1	3	0.36
yeah maybe	0.18 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0.1 result: 0.18	1	3	0.18

Disregard reward values because this is generated with mocked OpenAI and without *.lock files excluded

gentlementlegen commented 2 months ago

Ran with my OpenAI key, looks ok

And does not work on the current development branch which proves that the changes fixes it.

We might want to add files to linguist on the other repository like yarn.lock before re-running the text-conversation-reward

ubiquity-os-beta[bot] commented 1 month ago

@whilefoo, this task has been idle for a while. Please provide an update.

ubiquity-os-marketplace / text-conversation-rewards

Fix parent commit #282

@zugdev

Contributions Overview

Conversation Incentives

@rndquu

Contributions Overview

Review Details for #1

Conversation Incentives

@0x4007

Contributions Overview

Conversation Incentives

@gentlementlegen

Contributions Overview

Conversation Incentives

@whilefoo

Contributions Overview

Review Details for #1

Conversation Incentives