search

ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

Feat ubiquibot logger support #16

Closed gitcoindev closed 8 months ago

gitcoindev commented 8 months ago

Resolves #5

gitcoindev commented 8 months ago

This is still a draft pull request. I have to rebase to current development branch, hopefully will be ready for the review tomorrow.

gitcoindev commented 8 months ago

Hi @pavlovcik @whilefoo I seem to got it right this time -) I rebased the pull request against latest development branch as well.

The QA was done on my ubiquibot-kernel fork and supabase instance:

╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
[wrangler:inf] POST /events 200 OK (1137ms)
Skipping bot comment
        › Event issue_comment received (id: 7f262fc0-bf97-11ee-9890-dc018251cba6)
        › { id: '7f262fc0-bf97-11ee-9890-dc018251cba6',
            caller: 'file:///home/korrrba/work/ubiquibot-kernel-logging/ubiquibot-kernel/.wrangler/tmp/dev-MzUUmX/worker.js:24018:16',
            revision: null }
        › 
        ✓ Event issue_comment received (id: 7f262fc0-bf97-11ee-9890-dc018251cba6)
        ✓ { log: 'Event issue_comment received (id: 7f262fc0-bf97-11ee-9890-dc018251cba6)',
            level: 'info',
            metadata: 
             { id: '7f262fc0-bf97-11ee-9890-dc018251cba6',
               name: 'issue_comment',
               caller: 'file:///home/korrrba/work/ubiquibot-kernel-logging/ubiquibot-kernel/.wrangler/tmp/dev-MzUUmX/worker.js:24018:16',
               revision: null } }
        ✓ 
Event issue_comment received (id: 7f262fc0-bf97-11ee-9890-dc018251cba6)
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
[wrangler:inf] POST /events 200 OK (11ms)
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [b] open a browser, [d] open Devtools, [l] turn off local mode, [c] clear console, [x] to exit

Also tested at https://github.com/gitcoindev/ubiquibot/issues/10#issuecomment-1917572282 and received "Hello from the worker" comments.

On the way I also bumped wrangler to the latest version 3.25.0 .

0x4007 commented 8 months ago

Also tested at https://github.com/gitcoindev/ubiquibot/issues/10#issuecomment-1917572282 and received "Hello from the worker" comments.

Your test doesn't explicitly show that the logger is working but I trust that you tested that as well

gitcoindev commented 8 months ago

Also tested at gitcoindev/ubiquibot#10 (comment) and received "Hello from the worker" comments.

Your test doesn't explicitly show that the logger is working but I trust that you tested that as well

Yes, I can confirm that. I have logged into my Supabase dashboard and checked that a new row appeared in the logs table.