search

ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

Deprecate `keys` in config (`evmPrivateKeyEncrypted`, `openAi`) #22

Closed 0x4007 closed 7 months ago

0x4007 commented 7 months ago

Given that we figured out how to authenticate requests as the bot, wouldn't it make sense for us to read the raw key directly from their organization/repository secrets? Then we no longer need to include sensitive data inside of these public yml files. https://chat.openai.com/share/ba4e137d-4882-4c7a-b23a-2fcb541c83fb

rfc @rndquu @whilefoo

Originally posted by @pavlovcik in https://github.com/ubiquity/pay.ubq.fi/pull/154#pullrequestreview-1884346188

0x4007 commented 7 months ago

evmPrivateKeyEncrypted - I researched GitHub App permissions and its a boolean for all organization secrets or none; or all repository secrets or none. I think that partners may be weary to share ALL secrets so perhaps it makes sense to proceed with the X25519 evmPrivateKeyEncrypted system.

ubiquibot[bot] commented 7 months ago 
# Issue was not closed as completed. Skipping.
0x4007 commented 7 months ago

evmPrivateKeyEncrypted - I researched GitHub App permissions and its a boolean for all organization secrets or none; or all repository secrets or none. I think that partners may be weary to share ALL secrets so perhaps it makes sense to proceed with the X25519 evmPrivateKeyEncrypted system.

PSA @ubiquity/software-development

molecula451 commented 7 months ago

sense to proceed with the X25519 evmPrivateKeyEncrypted system.

What do you mean by proceed pavlovcik? proceed in removing the system?

0x4007 commented 7 months ago

Let's continue using the system.