search

ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

Secure https plugins #48

Closed whilefoo closed 3 months ago

whilefoo commented 4 months ago

Resolves #43

0x4007 commented 3 months ago

Glad to see that you are pushing code again.

gentlementlegen commented 3 months ago

@whilefoo Thank you for this. Will you take care of implementing it in the relevant plugins as well?

whilefoo commented 3 months ago

Yes I have implemented it in command-query-user because I needed to test it, but I'm not sure which plugins we plan to switch to workers. All plugins are short-running so I guess we can switch all?

gentlementlegen commented 3 months ago

I believe that https://github.com/ubiquibot/comment-incentives and https://github.com/ubiquibot/user-activity-watcher would remain as Actions because they might be long running tasks. Otherwise since all the others are handling commands yes I believe they can all be Workers (and I think it's already the case).

Side note, plugins can even be hybrids with both Worker and Action if that is ever necessary someday.