search

ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

Update packages #49

Closed whilefoo closed 3 months ago

whilefoo commented 3 months ago

Some packages were outdated and by upgrading the packages the types have changed so I had to fix that

whilefoo commented 3 months ago 
tests/main.test.ts(139,18): error TS2339: Property 'incentives' does not exist on type '{ plugins: { status: { name?: string | undefined; description?: string | undefined; command?: string | undefined; example?: string | undefined; uses: { id?: string | undefined; type: "github"; plugin: string | GithubPlugin; with: { ...; }; }[]; skipBotEvents: boolean; }[]; ... 301 more ...; "*": { ...; }[]; }; }'.

@gentlementlegen this test doesn't make sense to make because the config is not correct for the kernel, maybe you meant that as plugin config?

Out of curiosity, why do we never pin packages to a specific version?

I'm not sure, but we probably should. What ends up happening is that we have ^12.1.0 in the package.json but yarn install will install 12.6.0 which might break something even though it shouldn't according to the convention.

gentlementlegen commented 3 months ago

@whilefoo I think this test was done before we updated the config, so it was using the old bot config and was valid. I didn't spot it since the test still works due to the mock, I should be changed indeed.

I also agree with that, we should definitely set packages to a specific version moving forward.

rndquu commented 3 months ago

Regarding this CI run

Can we simply:

  1. @ts-ignore this line since https://github.com/ubiquity/ubiquibot-kernel/issues/31 has already taken too much dev effort for a single tsc error
  2. Remove this line if incentives is no longer present in the kernel's config