search

ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

ci: fix cspell #60

Closed rndquu closed 3 months ago

rndquu commented 3 months ago

This PR fixes:

  1. cpell CI error
  2. knip CI error (notice that since knip workflow uses pull_request_target changes will be seen only after this PR is merged)
github-actions[bot] commented 3 months ago

Unlisted dependencies (1)

Filename unlisted
tests/mocks/hello-world-plugin.ts msw
gentlementlegen commented 3 months ago

Any reason not to run Knip on pull_request like in other repositories?

rndquu commented 3 months ago

Any reason not to run Knip on pull_request like in other repositories?

I don't know why it was updated from pull_request to pull_request_target. Removing knip completely would've already saved us tremendous amount of dev time.

@gitcoindev Could you setup the knip workflow correctly in this repo?

gitcoindev commented 3 months ago

Any reason not to run Knip on pull_request like in other repositories?

I don't know why it was updated from pull_request to pull_request_target. Removing knip completely would've already saved us tremendous amount of dev time.

@gitcoindev Could you setup the knip workflow correctly in this repo?

Yes, I am on it.

gitcoindev commented 3 months ago

I had quite a hectic day today, started on Knip but was distracted multiple times, I will submit a PR on Friday till EOD.