search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
16 stars 59 forks source link

feat: changed the migrations to reflect the new database schema #923

Closed gentlementlegen closed 2 months ago

gentlementlegen commented 3 months ago

Resolves #919

Follows up PR https://github.com/ubiquity/ubiquibot-kernel/pull/33

0x4007 commented 3 months ago

I don't know enough about migrations to understand this pull well enough.

gentlementlegen commented 3 months ago

It is a literal db dump as I didn't know myself what functions were written in the database. It is useful to get the exact same state as the current DB is now for local or self hosted dev purposes. Since we gonna have one DB per module it shall be irrelevant soon.

0x4007 commented 3 months ago

Since we gonna have one DB per module it shall be irrelevant soon.

Perhaps one KV per module instead

gentlementlegen commented 2 months ago

@whilefoo I think it would be important to get this in because many newcomers do not have the schema migrations to work locally, and do not have access to the current production database. While I do understand your concern about cleanliness of the file, it is auto generated and I don't have much control over it, and there is no option to prettify the output, only options being documented here.

whilefoo commented 2 months ago

Sorry, I didn't know you were waiting for me