search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
16 stars 59 forks source link

Merge Refactor/move to delegated compute into Development #929

Closed gentlementlegen closed 1 month ago

gentlementlegen commented 1 month ago

Resolves #927

@0x4007 @gitcoindev Re-opening the same PR here just to have develop up-to-date and the issue closed.

gentlementlegen commented 1 month ago

@0x4007 Or should have I not merged? Dunno what is the status of develop against this branch, sorry about that.

0x4007 commented 1 month ago

It's fine unless something breaks lol

gentlementlegen commented 1 month ago

@0x4007 Major change is yarn -> bun. Code base seems to follow the same logic. Let's see if the deployment fails, I'll revert.

0x4007 commented 1 month ago

https://github.com/ubiquity/ubiquibot/commit/bc4baaf2a9c9b4f3e899ba28ec2494f446360ff9#commitcomment-142323292

gentlementlegen commented 1 month ago

bc4baaf#commitcomment-142323292

@0x4007 Should this mean I should revert? Or just update that file back with all the data

0x4007 commented 1 month ago

Just revert the value to what it was originally.

gentlementlegen commented 1 month ago

@0x4007 Yep this is done. Also the fix I made should go in. Can revert bun update if you want, it was for me to be able to run on Windows, previous version doesn't work.

0x4007 commented 1 month ago

No comment on bun

gentlementlegen commented 1 month ago

@0x4007 Ran this version inside my own repo for testing, commands seem to respond fine. https://github.com/Meniole/bot/issues/4#issuecomment-2133152807 This version should be working and safe to merge!

0x4007 commented 1 month ago

Check the files view at the bottom. There's an e2e test error related to config!

Also somehow Knip reporter has been running for six days...not sure how that is possible @gitcoindev 👀

Screenshot 2024-05-30 at 15 05 38
gitcoindev commented 1 month ago

Check the files view at the bottom. There's an e2e test error related to config!

Also somehow Knip reporter has been running for six days...not sure how that is possible @gitcoindev 👀

Screenshot 2024-05-30 at 15 05 38

lol let me check this. Six hours should be maximum but normally it takes less than 1 second to execute.

gitcoindev commented 1 month ago

@0x4007 @gentlementlegen I found a most likely cause for the six days run mentioned above - the knip commands were incorrect in package.json and the wokrflow was in a busy loop. The incorrect commands look like an integration error in one of the previous prs. I fixed this and opened https://github.com/ubiquity/ubiquibot/pull/933 . Knip is supposed to fail with findings in this repo and as discussed with @rndquu we will not fix it here since this repo is deprecated, but Knip workflow itself was fixed to avoid leaking secrets with potential malicious pull requests.

gitcoindev commented 1 month ago

For this PR I am not sure about configuration error https://github.com/ubiquity/ubiquibot/actions/runs/9210992288/job/25339291201?pr=929 @gentlementlegen could you please share any information on that?

gentlementlegen commented 1 month ago

@gitcoindev Seems that during the tests, env variables were not populated as seen here

So when the configuration is tested it fails as it is undefined.