search

ubports / ubuntu-touch

Ubuntu Touch's issue inbox is now migrated to GitLab.
https://gitlab.com/ubports/ubuntu-touch
1.29k stars 109 forks source link

fingerprint support for oneplus 3? #1315

Open linsmod opened 4 years ago

linsmod commented 4 years ago

I found fingerprint unlock on meizu is supported, is it possible take it to oneplus3?

Flohack74 commented 4 years ago

Well its not really working in the new xenial image we use. The component used by Canonical has some closed source stuff which was only working for vivid I think. See also here: https://github.com/ubports/ubuntu-touch/issues/396 - So I would consider this issue as being blocked by 396

Vince1171 commented 4 years ago

To support fingerprint scanner for op3 we "just" have to implement biometryd for the op3. The problem is: No one know how to do that. As Flohack said, the only known implementation is for the meizu pro5 but we don't have the source for it. So we have no idea how it has been done...

Flohack74 commented 4 years ago

Lets reverse-engineer it ;)

linsmod commented 4 years ago

@Flohack74 well, good idea :)

dobey commented 4 years ago

What one should do instead, is to implement a plug-in for biometryd, which instead of being device-specific (as the proprietary pro 5 blob is), uses libhybris to access the biometry interface through the Android HAL. This would then be generic and should work on more devices.

Flohack74 commented 4 years ago

Maybe we can borrow from Sailfish. They got something that might work. Our plugin would just need to have the code from fpd-slave probably:

sailfish-fpd <> sailfish-fpd-slave <> libgbinder <> Android BSP HAL: android.hardware.fingerprint

linsmod commented 4 years ago

you mean the sailfish-fpd-slave is a bridge between
Android service and uplevel os， so can use the code build one middleware to translate api calls between them？

linsmod commented 4 years ago

will be a good idea if Sailfish support the op3 fingerprint.

Flohack74 commented 4 years ago

Yes I mean that. But its unsure if we can use it in the same way, someone needs to investigate.

Flohack74 commented 4 years ago

@dobey biometryd is not installed at all in our rootfs, should we prepare this to be able to play with it a bit better?

dobey commented 4 years ago

@dobey biometryd is not installed at all in our rootfs, should we prepare this to be able to play with it a bit better?

What? Of course biometryd is installed in the rootfs. I'm not sure why you would think it isn't, as system-settings requires it.

Flohack74 commented 4 years ago

Hmm sorry I thought its an overlay, so I only looked into ubports-meta lists...

MoemUT commented 3 years ago

If this ever happens, I will buy the person who makes it happen a beer! 🍻