ubsicap / dbl.local.electron

Nathanael - Electron front-end for DBL dot Local
MIT License
1 stars 0 forks source link

Nathanael - deal with list performance issues #13

Closed ericpyle closed 6 years ago

ericpyle commented 6 years ago

Here's a perf taken when adding bundles via SSE to the list:

image

ericpyle commented 6 years ago

Here's Perf.printWasted() for toggling a bundle

image

ericpyle commented 6 years ago

Here's Perf.printOperations() for toggling a bundle

image

ericpyle commented 6 years ago

Done in https://github.com/ubsicap/dbl.local.electron/releases/tag/v0.6.0

Basically had to make a PureComponent that encapsulated each row, and then follow best practices to not cause performance issues that would re-render each row needlessly.

Searching could still use some improvement, I think, but it's very much improved.

If needed we could go further, we could add something like redux-debounced for SSE actions that may cause slow down. Or React Virtualized https://github.com/bvaughn/react-virtualized which only re-renders what the user sees on the screen.