ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

Implementation of functional programming functions question. #20

Closed kylemasc917 closed 1 week ago

kylemasc917 commented 1 week ago

Would it be preferable if we had two separate modules one for each functional programming function or use both of them in the same module?

laserlab commented 1 week ago

only use one module, but it can have many functions

laserlab commented 1 week ago

think of the module as the library for your electrodynamics problem.

you can and it is also preferable to have a second module for the unit tests

kylemasc917 commented 1 week ago

I've submitted a pull request under the given assumption from what you've described: File containing all modules -algorithm module that solves the ED problem using functional programming -unit test for the algorithm

Is there anything else I am missing?

laserlab commented 1 week ago

Just had a look at your PR. While somewhat complex this works as a function in a function.

laserlab commented 1 week ago

You can have a look at the linting output of the check inside the PR for some ideas what is missing ... docstrings ...

kylemasc917 commented 1 week ago

I have edited both files to improve linting output especially adding more docstrings.