ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.34k stars 181 forks source link

Some missing mimetype icons #2334

Open madsrh opened 4 years ago

madsrh commented 4 years ago

Here's a few more mimetype icons we can add if anyone want's something to work on :) Some of these are pretty rare or even legacy, so here's a list to pick from in no particular order. Most of these can be tested with the files here.

Jupi007 commented 4 years ago

😳 There is a lot! I'll think about them tomorrow.

@ubuntujaggers I think there's plenty of work for two. πŸ˜‹

madsrh commented 4 years ago

I know πŸ˜… Again, some of these are pretty crazy. We can add a 30.04 tag?

Feichtmeier commented 4 years ago

We can just add it to backlog :shrug: And you use this issue to manage individual issues and manage the ToDo list. I would then create an issue for each individual icon and link them to the ToDo list entries. PR's can have multiple Closes #123142342XYZ but for issues I would really stick to 1 icon 1 issue to handle it easier.

Muqtxdir commented 3 years ago

hi, could we also add text/x-xmi to the list as well ?

madsrh commented 3 years ago

hi, could we also add text/x-xmi to the list as well ?

OFC @Muqtxdir ! Can you edit the list yourself? Feel free to add more, if you come across any thing we're missing

Muqtxdir commented 3 years ago

OFC @Muqtxdir ! Can you edit the list yourself? Feel free to add more, if you come across any thing we're missing

umm, i don't think I have the permission to edit

Muqtxdir commented 3 years ago

also add application/x-r-project to the list from #2374 πŸ˜… (I forgot to mention that)

Jupi007 commented 3 years ago

I also added the application/x-msdownload (.dll) mimetype to the list:

Capture d’écran du 2020-10-15 12-20-29

stuarthayhurst commented 3 years ago

Would symlinking application/x-msdownload to the icon for application/x-mswinurl work?

Jupi007 commented 3 years ago

Would symlinking application/x-msdownload to the icon for application/x-mswinurl work?

I don't think so, this icon symbolize a link or an url. IMO we should use the application-octet-stream icon as dlls are binaries files.

stuarthayhurst commented 3 years ago

I made 2 mimetype icons for my icon theme in Yaru's style and was wondering if anyone wants them upstreamed? If anyone's interested, I'll do it later and submit a pull. (They are svgs, GitHub didn't like me uploading them

application-vnd ms-publisher application-x-qemu-disk

madsrh commented 3 years ago

Nice work @Dragon8oy πŸ‘

Jupi007 commented 3 years ago

It's very nice of you, thanks @Dragon8oy πŸ‘

I just have one question: what's the name of the related mimetypes?

stuarthayhurst commented 3 years ago

They're:

Jupi007 commented 3 years ago

Thanks πŸ™‚ The ms-publisher icon is good. But about the qemu one, we use the cardiogram pictogram only for virtualbox mimetypes. IMO you should replace it by something else (a symbolic version of qemu logo by example).

madsrh commented 3 years ago

But about the qemu one, we use the cardiogram pictogram only for virtualbox mimetypes. IMO you should replace it by something else (a symbolic version of qemu logo by example).

+1

https://wiki.qemu.org/Logo https://git.qemu.org/?p=qemu.git;a=blob_plain;f=pc-bios/qemu_logo.svg;hb=HEAD Color: #ff6600

stuarthayhurst commented 3 years ago

Thanks for the feedback, I've finished the publisher icon in your format and generated the bitmaps, I'll work on the qemu one and submit a pull tomorrow. Thanks :)

stuarthayhurst commented 3 years ago

image image Thoughts?

Jupi007 commented 3 years ago

Thoughts?

Much better! Make the pictogram a bit smaller (it is too close to the right edge actually IMO) and it will be perfect πŸ‘

stuarthayhurst commented 3 years ago

image Which colour did you prefer? Personally, I thought the dark grey was better.

Jupi007 commented 3 years ago

Perfect πŸ˜ƒ Personally I also prefer dark grey.

madsrh commented 3 years ago

Thoughts?

How does it look with a solid fill? Similar to the snap icon

stuarthayhurst commented 3 years ago

image

Jupi007 commented 3 years ago

Maybe also add an eye, what do you think of πŸ€”

stuarthayhurst commented 3 years ago

image I'm not too sure which I prefer so far. I tried it with an eye without a fill, and it didn't look right, but this looks much better than that attempt...

Jupi007 commented 3 years ago

I'm not too sure which I prefer so far. I tried it with an eye without a fill, and it didn't look right, but this looks much better than that attempt...

It is the best version IMO :+1:

stuarthayhurst commented 3 years ago

I'm happy with it, but I'll wait for some more input before I submit a PR, thanks guys :)

Jupi007 commented 3 years ago

thanks guys :)

No, thank you πŸ™‚

stuarthayhurst commented 3 years ago

image image These are the two, I'll submit whichever your team prefer :)

Jupi007 commented 3 years ago

Definitively prefer the solid one ;)

bryce-carson commented 3 years ago

I'm not much for graphic design, or working with templates in Inkscape, but I've created an icon for myself for R Markdown files.

The shape of the icon is definitely not Yaru, nor Adwaita, but comes instead from the hexagonal shapes that R Studio likes to use for their different little projects (like Tidyverse, knitR, readR, etc.). Derivative Original
text-x-r-markdown r-markdown-logo