ucfopen / labeling-materia-widget

Materia widget where students select items and use them to label parts of an image.
GNU Affero General Public License v3.0
1 stars 4 forks source link

Issue/15 implement 3 d model page route #27

Open emanuelGitCodes opened 2 years ago

emanuelGitCodes commented 2 years ago

Review changes done to implement 3d models.

FrenjaminBanklin commented 2 years ago

Piggybacking from @clpetersonucf's comment: don't forget that just deleting those files and folders is only step one. You'll also need to runBFG or some other sort of utility to remove all of the 3D model files from the repository's history entirely.

emanuelGitCodes commented 2 years ago

Agree; once the changes have been done and verify that will be the next step.

clpetersonucf commented 2 years ago

Okay, using the updated version of the branch, a few additional notes:

Screen Shot 2021-10-27 at 12 51 23 PM

I'm not sure what the best solution for this. Would it be possible to dynamically adjust the sphere size based on the dimensions of the model?

My previous notes about the line toggle and center camera buttons not working in the player were incorrect, that behavior is now working with the latest commit on the branch. :+1:

clpetersonucf commented 2 years ago

This is continuing to look better and better. Some more feedback for the creator specifically, as the experience becomes more refined: