Closed cayb0rg closed 11 months ago
Everything looks really good and keyboard interactions are great, only a couple of minor things I can think of:
aria-label
of the keyboard instructions button (or whatever the nearest convenient element is that is reachable in the tab order) to the full text of the keyboard instructions so unsighted users don't even have to open a dialog to get the information.As for the order in which destinations are cycled through, I think the current approach of keeping them in a predictable order all the time would be better than the order changing depending on whether some of them are unassigned or not.
Nice catches. The latest changes include:
New changes to Creator
options
instead of question
. Thanks for the heads up! New changes to Player
I'll keep thinking on this, but I'm not sure there is anything I can do to focus the first element without manually refocusing, which would read the aria label of the focused label before the ARIA live region update as it did before. It's currently focusing the next label in the list directly after the one the user just moved by default.
Closing, since these were incorporated into #36 which was approved and merged.
Adds keyboard navigation and partial screenreader accessibility to the player
Why partial? Describing destinations for the screenreader has not been implemented. It is possible we can add an additional input box in the creator for the author to add their own descriptions. For example, in the world map demo, the author could describe a label with some fact about that country or even describe the physical location: "Northern country east of the Atlantic Ocean", etc. This would essentially turn the game into Matching, but at least unsighted users could play.
Update: Added optional label descriptions to the creator. Screenreader accessibility is left up to the author to make labels make sense.
Escape"H": Open/Close the instructionsQuestion on destination navigation: should the player cycle through unfilled destinations first, or would this be too confusing?
To-Do
More descriptive labels