uclahs-cds / package-moPepGen

Multi-Omics Peptide Generator
https://uclahs-cds.github.io/package-moPepGen/
GNU General Public License v2.0
6 stars 1 forks source link

Fix MNV and generateIndex #817

Closed zhuchcn closed 1 year ago

zhuchcn commented 1 year ago

Description

Two issues fixed in this PR:

  1. Adjacent variants were not merged as MNVs successfully. The function always exited with nothing.
  2. Because of the updating to on-disk GTF, the coding transcripts were not generated and saved successfully. filterFasta is the only command affected.

Closes #...

Checklist

lydiayliu commented 1 year ago

Adjacent variants were not merged as MNVs successfully. The function always exited with nothing.

None of them? XD Were the MNVs directly from VEP at least treated properly?

zhuchcn commented 1 year ago

None of them? XD Were the MNVs directly from VEP at least treated properly?

Those are fine. Just the adjacent grouping wasn't done. I moved around the code block a couple of times and it must go wrong then. It was a bad decision not to have any test cases.

zhuchcn commented 1 year ago

There might be still some inconsistency between mpg and bruteForce in turns of adjacent merged MNVs. I'll keep working on this but will merge it right now.