uclamii / model_tuner

A library to tune the hyperparameters of common ML models. Supports calibration and custom pipelines.
Apache License 2.0
3 stars 0 forks source link

Feature selection not printing features selected unless feature_selection=True input is specified #98

Closed lshpaner closed 1 week ago

lshpaner commented 1 week ago

Problem

When passing ("rfe", rfe) into the pipeline steps, the model will still run, but no output specific to feature names generated is produced unless the user explicitly passes the input feature_selection=True.

Solution

Either:

Create a custom exception that forces the user to set feature_selection to True if passing rfe into the pipeline

or :

Create an if block that sets feature_selection=True when rfe is detected in pipeline_steps.

lshpaner commented 1 week ago

on second thought, it's best to just specify this in the docs; closing issue.