search

ucsb-cs156-f24 / proj-courses-f24-01

https://ucsb-cs156-f24.github.io/proj-courses-f24-01/
1 stars 0 forks source link

Junhyung getactivequarterlist component #23

Closed Neamal closed 4 days ago

Neamal commented 1 week ago

Closes #18

Dokku Deployment: https://courses-dev-neamal.dokku-01.cs.ucsb.edu/#

Finished the getActiveQuarterList method in the UCSBApiQuarterService file and created an endpoint called activeQuarters in the controllers file. Also created tests for both the getActiveQuarterList method as well as the endpoint. Passed all of the tests including coverage and stryker. Below is a picture of the component in Swagger as it lists all of the dates until 20244 which was listed in my test file.

image

pconrad commented 4 days ago

@Neamal this looks good, and I think we can get it merged soon. Just one thing: can you do this on your dokku instance?

dokku config:set courses-dev-neamal END_QTR=20251

It should restart your app after you do this. This is needed because otherwise, the endpoint will "count backwards" from the current quarter to the END_QTR, which is not what we want. We need to test the app with values that are realistic.

Then I think we can get this one merged.