search

ucsb-cs56-projects / cs56-utilities-GEAR-scraper

-
0 stars 4 forks source link

Issue #1 + optional part #3

Closed alanbuzdar closed 10 years ago

alanbuzdar commented 10 years ago

Use "ant run" to run. And "ant runWithGui" to run with gui. @andrewberls Issue #1 20 pts for: Getting Proper Libraries 700 pts for: Implemented working GEAR_Scraper Followed CoEGECourse implementation CLI with more advanced features than requested 280 pts for: GUI Custom URLs

~requested: 1000

andrewberls commented 10 years ago

GitHub is having trouble showing me inline diffs so I'll aggregate all comments here. I see pdfbox included as a jar - is there a reason its source tree is included as well?

Overall, the app is looking really good! The command-line interface is really neat, and the GUI works well. It looks like there are a couple places in the code that have some pretty intense conditionals, such as in GearScraper.isCourse() or GECourse.setDeptCode(). I'm not certain what an ideal solution would be, but one possibility is to look into data structures such as HashMaps which could potentially clean things up quite a bit.

Finally, there are comments sprinkled throughout the code, but I think there's an opportunity to expand on some of the and clarify the high-level "goal" of each method.

andrewberls commented 10 years ago

PROJ1 MOD REVIEW DONE

kjorg50 commented 10 years ago

Hi @alanbuzdar, instead of including the source code for pdfbox in your lib/ folder, you can use this jar from the following download page:

http://www.apache.org/dyn/closer.cgi/pdfbox/1.8.4/pdfbox-app-1.8.4.jar

I tested it out for the other pdf-scraper project, and all the code still compiled and passed the tests. Can you make this change here?

alanbuzdar commented 10 years ago

@kjorg50 Done!