ucsd-dsm / dsm-docker

Docker containers used by other projects
0 stars 0 forks source link

deprecate this repo #1

Closed lz100 closed 8 months ago

lz100 commented 8 months ago

Move contain in this repo to dsm-dockers if the container is still required, otherwise directly delete this repo.

januz commented 8 months ago

@ocelhay I think that we are currently still using this container, right? But I am hoping that we move everything from Shinyapps.io to ShinyProxy and can then delete this repo?

lz100 commented 8 months ago

I can reformat docker file and gh workflow in this repo and move them to my new repo. If we write new docker files for ShinyProxy, we can simply add new images to dsm-dockers

ocelhay commented 8 months ago

@ocelhay I think that we are currently still using this container, right?

Yes, we are still using it for abcd-metrics and recover-metrics.

But I am hoping that we move everything from Shinyapps.io to ShinyProxy and can then delete this repo?

Here is the status of the different apps:

abcd-metrics shinyapps.io with container. Beta ShinyProxy ready. abcd-ra-tools ShinyProxy abcd-tlfb ShinyProxy abcd-zoom-attendance shinyapps.io manual deployment

recover-metrics shinyapps.io with container.

hbcd-metrics shinyapps.io manual deployment. Beta ShinyProxy ready. hbcd-recruitment shinyapps.io manual deployment hbcd-tlfb shinyapps.io manual deployment

The hbcd-tlfb is the one that is going difficult to transition due to the need to coordinate with LORIS.

We probably want to keep the container for abcd-metrics (temporary) and recover-metrics. @lz100 We can just edit these github workflow files.

@januz I assume switching recover-metrics and abcd-zoom-attendance apps to ShinyProxy isn't a priority, but something we nevertheless want to do?

lz100 commented 8 months ago

The new images we plan to build and store on docker hub instead of github. I can rebuild your current image on docker hub, and you just need to change the registry, one line of code, in your github workflow files. Does it sound good?

ocelhay commented 8 months ago

The new images we plan to build and store on docker hub instead of github. I can rebuild your current image on docker hub, and you just need to change the registry, one line of code, in your github workflow files. Does it sound good?

Yes, please add it to dockerhub and send me the link to the image. If it's a public image, I guess that changing one line of code will work. Thanks!

januz commented 8 months ago

Yes, let's do that for now but thanks for the update on the status of deploying apps using ShinyProxy for the different apps. That's something I wanted to talk about later either way :) Agreed that there are a few apps with lower priority but we should try to switch everything over at some point to make maintenance more streamlined (and to save money by cancelling shinyapps.io).

ocelhay commented 8 months ago

@lz100

I am going to replace:

    container:
      image: ghcr.io/ucsd-dsm/shiny-rsconnect:main

with

    container:
      image: hub.docker.com/r/ucsddsm/rsconnect

Does it look like a reasonable attempt?

lz100 commented 8 months ago
    container:
      image: ucsddsm/rsconnect:r4.3

For default (hub.docker.com), you don't need to specify the registry URL also

      credentials:
         username: ${{ github.actor }}
         password: ${{ secrets.github_token }}

remove this part. Public images don't need credentials

ocelhay commented 8 months ago

That works great - Thanks, Le! I think we can delete this repo now.