Upgraded hyrax to include the commit that corrected the FlipFlop typo.

ucsdlib / damspas-rd

A Digital Collections application based on Hyrax

MIT License

3 stars 2 forks source link

Upgraded hyrax to include the commit that corrected the FlipFlop typo. #113

Closed lsitu closed 7 years ago

lsitu commented 7 years ago

Upgraded hyrax to include the commit that fixed the FlipFlop typo.

@ucsdlib/developers - please review

hweng commented 7 years ago

@lsitu Looks good. But the ticket requires to update to latest commit. And your upgrades check out the commit 22 days ago: https://github.com/samvera-labs/hyrax/commit/6688333c9343fd7d2e19594661522a826d871951

There are new updates or fixes added to hydra master branch in the past 22 days, our local development might be conflict with it. It's better to stay up to date with Hyrax development. Could you update to the latest or more recently one?

mcritchlow commented 7 years ago

@hweng - In our planning meeting yesterday, we agreed that @lsitu would update to this commit in order to rebase and merge #108 , and then in a separate commit/PR he would update to the most recent commit possible.

It is true that this won't fix #110 as described, so perhaps we could remove that from the commit message/PR title?

hweng commented 7 years ago

@mcritchlow Yup, sounds good to me.

lsitu commented 7 years ago

@mcritchlow @hweng Done to remove #110 reference.

mcritchlow commented 7 years ago

Assuming Circle-CI is happy, LGTM 👍

coveralls commented 7 years ago

Coverage remained the same at 91.846% when pulling 6225749a307431494d2e1795057d4c7d77772bc6 on feature/flipflop_typo into 5f4bedc839a7fa52fea48dc95840b82442263df6 on develop.