search

udoprog / c10t

A minecraft cartography tool
Other
225 stars 50 forks source link

Palette overhaul; replaces the old hardcoded numeric id based palette … #308

Closed evildeeds closed 3 years ago

evildeeds commented 3 years ago

Palette overhaul; replaces the old hardcoded numeric id based palette with the modern namespaced palette loaded from an external json file. For issues #301 #303 #307

Now I have seen that @tanaka141 have been working on supporting the map format; this patch does only deal with the internal palette to support modern versions of Minecraft, it does not fix any missing blocks or handle the new map format itself, but does enable editing the palette without needing to recompile.

Since this is a rather large change I'm pushing it as a pull request for review.

evildeeds commented 3 years ago

Well; I think that will have to do, I'll wait a bit longer for any feedback before merging and in the meantime I'll have a go at trying to handle the new map format (I suppose it isn't that new any longer..).

As for a code clean up run which kind of is needed, that will have to wait for a bit longer.

udoprog commented 3 years ago

Well; I think that will have to do, I'll wait a bit longer for any feedback before merging and in the meantime I'll have a go at trying to handle the new map format (I suppose it isn't that new any longer..).

As for a code clean up run which kind of is needed, that will have to wait for a bit longer.

Kudos for any work you want to do! Just make sure it's on your own behest and you think it's fun. I have other projects I've moved on to!

FWIW, on the surface the patch looks fine to me!

evildeeds commented 3 years ago

Well; I think that will have to do, I'll wait a bit longer for any feedback before merging and in the meantime I'll have a go at trying to handle the new map format (I suppose it isn't that new any longer..). As for a code clean up run which kind of is needed, that will have to wait for a bit longer.

Kudos for any work you want to do! Just make sure it's on your own behest and you think it's fun. I have other projects I've moved on to!

FWIW, on the surface the patch looks fine to me!

Let me put it this way; I have two reasons for picking this project up again, first Minecraft somehow became relevant once again and I also felt that I need to refresh my C++. And so what better way is there but to pick this back up as quite a bit of maintenance is required before it can work with newer maps. I'm currently working on consolidating block lookup code from the rendering decision switch-blocks and into level handling code, which I think is necessary to prime the code base for handling a second map type.

Edit: There is also a situation related to an ongoing epidemic meaning that I'm going nowhere, so to avoid being completely bored out of my mind during these holidays...