search

ugent-library / biblio-backoffice

Apache License 2.0
7 stars 0 forks source link

Plato imports: embargo date incorrect #1726

Open mietcls opened 2 weeks ago

mietcls commented 2 weeks ago

Bug description

Plato imports: embargo date does not switch

Steps to Reproduce

  1. Go to suggestions: https://backoffice.biblio.ugent.be/candidate-records
  2. See imported plato suggestion, with embargo date still active: SCR-20241014-ouje
    • e.g. Towards the Next Generation of Geometric Phase Photonic Components Using Chiral Liquid Crystal
    • Open access from 2024-10-01
    • Claimed on On 2024-10-10
  3. See import itself Screenshot 2024-10-14 at 16 51 13 (changed manually by Biblio team member)

Automatic testing scenario

Possible @verheyenkoen ?

Expected behavior

The "switch" for the embargo happens in the suggestion itself, just like for the ones we create ourselves in Biblio. The Biblio team does not need to see that information in the suggestion if the embargo is already passed.

Risk classification

Likelihood

How often does this happen? 3: Occasional

Consequences

2: Critical

mietcls commented 2 days ago

@verheyenkoen I've removed on hold, the decision has been made to make the switch inside the suggestion already. Later, when we have a more granular history, we can perhaps add a view that shows what data we got from Plato originally.