Go vet warnings - Githubissues

ugorji / go

idiomatic codec and rpc lib for msgpack, cbor, json, etc. msgpack.org[Go]

MIT License

1.86k stars 295 forks source link

Go vet warnings #183

Closed mrz1836 closed 7 years ago

mrz1836 commented 7 years ago

vendor/github.com/ugorji/go/codec/gen-helper.generated.go:1: possible malformed +build comment vendor/github.com/ugorji/go/codec/simple.go:343: unrecognized printf verb ' ' exit status 1

ugorji commented 7 years ago

The first one is not a bug, and cannot be solved, as we want a way to comment this out. I think the vet tool should be changed to not flag this.

The second one is a bug, and I have now fixed (but not uploaded upstream yet)

ugorji commented 7 years ago

K - I can change it to / / to prevent "vet" from flagging as a potential issue.

Fix coming soon.

ugorji commented 7 years ago

Fixed with 2 changes above