Closed alexander-haller closed 2 months ago
In GitLab by @mhxion on Mar 28, 2024, 24:36
requested review from @alexander-haller
In GitLab by @project_994_bot_1f89ebd5af89f5e987c71c650dd64895 on Mar 28, 2024, 24:36
added 2 commits
In GitLab by @project_994_bot_1f89ebd5af89f5e987c71c650dd64895 on Mar 28, 2024, 24:55
added 1 commit
In GitLab by @mhxion on Mar 28, 2024, 02:49
With this improved PermissionValidator
it's now more clear what needs what permission. I wasn't 100% sure before, but bill-teams
can run totally on read-only token which makes sense of course.
We can also update the eLabFTW API tokens in ansible to read-only tokens (write now the tokens have write permission).
In GitLab by @project_994_bot_1f89ebd5af89f5e987c71c650dd64895 on Mar 28, 2024, 03:07
added 2 commits
In GitLab by @project_994_bot_1f89ebd5af89f5e987c71c650dd64895 on Mar 28, 2024, 03:41
added 2 commits
In GitLab by @project_994_bot_1f89ebd5af89f5e987c71c650dd64895 on Mar 28, 2024, 03:49
added 1 commit
In GitLab by @project_994_bot_1f89ebd5af89f5e987c71c650dd64895 on Mar 28, 2024, 03:52
added 1 commit
approved this merge request
In GitLab by @mhxion on Mar 28, 2024, 10:44
Thanks for approving!
In GitLab by @project_994_bot_1f89ebd5af89f5e987c71c650dd64895 on Mar 29, 2024, 01:22
added 1 commit
In GitLab by @mhxion on Mar 29, 2024, 01:24
Commit 22cff8e8 fixes #26.
In GitLab by @mhxion on Mar 29, 2024, 01:38
mentioned in commit 0325afb71f7aa952732715f1f30eef78b6cbd0da
In GitLab by @mhxion on Apr 2, 2024, 17:02
mentioned in commit 5e377d647aade8f7604b3e3656e02b156f813b9a
In GitLab by @mhxion on Apr 2, 2024, 17:14
Re-merge/base to dev
without squashing. new-bill-teams
that was branched off of fix-minor-bugs
was never squashed which caused a merge-conflict when trying to merge new-bill-teams
with dev
.
In GitLab by @mhxion on Mar 28, 2024, 24:36
Merges fix-minor-bugs -> dev
Besides the aforementioned bug fixes this PR improves
PermissionValidator
and adds support for validating R/W permission for using API token. Examples:Validate if API token has write permission
Validate if API token has read permission
Validate if a requesting user has at least
sysadmin
accessValidate if a requesting user has at least
sysadmin
access and belongs to a teamValidate if a requesting user has at least
admin
access with write permissionValidate if a requesting user has at least
user
access with read permission