search

uhmanoa-transpiler-project / shaka-scheme

The official repository for the UH Manoa Transpiler Project's Scheme interpreter, Shaka Scheme.
32 stars 24 forks source link

Completed migration of Environment #27

Closed dylannakahodo closed 7 years ago

dylannakahodo commented 7 years ago

I finished migrating the Environment code from the old-version-Spring-2017 branch.

I discussed with Austin regarding contains() in Environment, and we decided that it will only check for the key in the current Environment, while is_defined() will recursively check the current Environment and all parents.

I also added the unit-tests for Environment and updated documentation.

I think everything should be correct. Please let me know if you notice anything wrong with my implementation.

dylannakahodo commented 7 years ago

Finished documentation and comments that Austin had.

CinchBlue commented 7 years ago

Looks like the changes have all been addressed. I approve this pull request.