ui5-community / ui5-ecosystem-showcase

A repository showcasing the UI5 tooling extensibility to combine OSS tools for UI5 application development.
https://ui5-community.github.io/ui5-ecosystem-showcase/
Other
194 stars 93 forks source link

fix: handle case when lessToCompile is provided as a string value #1027

Closed marcelschork closed 4 months ago

marcelschork commented 4 months ago

As of now the ui5-tooling-less-task is not working when the configuration parameter lessToCompile is provided as a single string value.

customTasks:
   - name: ui5-tooling-less-task
     beforeTask: minify
     configuration:
       lessToCompile: 'theme/style.less'

A workaround is to use a list style.

customTasks:
   - name: ui5-tooling-less-task
     beforeTask: minify
     configuration:
       lessToCompile: 
         - 'theme/style.less'

I stumbled across it when migrating an old project from a colleague to UI5 tooling v3. We used a custom less compile task supporting single values and the switch to the official UI5 tooling task made me struggling.

petermuessig commented 4 months ago

LGTM - thanks for the fix