Closed shimwell closed 3 years ago
Merging #811 (651c67b) into develop (b7f31f8) will decrease coverage by
0.26%
. The diff coverage is91.66%
.
@@ Coverage Diff @@
## develop #811 +/- ##
===========================================
- Coverage 95.39% 95.13% -0.27%
===========================================
Files 74 74
Lines 5256 5257 +1
===========================================
- Hits 5014 5001 -13
- Misses 242 256 +14
Impacted Files | Coverage Δ | |
---|---|---|
paramak/utils.py | 99.61% <ø> (ø) |
|
paramak/neutronics_utils.py | 86.26% <83.33%> (-5.03%) |
:arrow_down: |
paramak/parametric_neutronics/neutronics_model.py | 93.72% <100.00%> (+0.08%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b7f31f8...651c67b. Read the comment docs.
Proposed changes
Removes a some code by adding a package dependency remove_dagmc_tags
The code removed uses mbconvert which is a system call and might not be installed on the host computer anyway
Types of changes
What types of changes does your code introduce to the Paramak? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...