search

ulisesbocchio / spring-boot-security-saml

spring-security-saml integration with Spring Boot
MIT License
157 stars 72 forks source link

entityId should default to null #60

Closed candrews closed 6 years ago

candrews commented 6 years ago

Having entityId default to "localhost" causes the default configuration of to disagree with the default configuration of Spring Security SAML which is surprising. Leaving it set to null ends up with an entityId of <entityBaseUrl>/saml/metadata as expected. See https://docs.spring.io/autorepo/docs/spring-security-saml/1.0.4.RELEASE/reference/html/configuration-metadata.html

candrews commented 6 years ago

This change allowed my application to authentication with my IdP, so I think it's a solid and worthwhile improvement.

ulisesbocchio commented 6 years ago

thanks, that makes sense, I pretty much left all the defaults untouched, don't remember why I defaulted entityID to localhost. Probably a selfish act of convenience for my sample apps...

ulisesbocchio commented 6 years ago

can you also please update the properties doc?

candrews commented 6 years ago

Done! I've updated this PR.

candrews commented 6 years ago

@ulisesbocchio could you please release a new version?