Closed RizwanMunawar closed 1 week ago
π Hello @RizwanMunawar, thank you for submitting an ultralytics/ultralytics
π PR! Your contribution to improving the seg_bbox
calculations is appreciated. To ensure a smooth review process, please go over the following checklist:
ultralytics/ultralytics
main
branch. If itβs behind, you can update it by clicking the βUpdate branchβ button or running git pull
and git merge main
locally.We noticed your PR focuses on optimizing the logic for segmentation bounding box labels, specifically improving performance and clarity by avoiding redundant calculations for absent labels. This enhancement not only cleans up the code but ensures a smoother developer experience! π οΈποΈ Lovely job documenting the changes in your PR description as well. π
If you havenβt already, please refer to our Contributing Guide to double-check everything required is in place. Feel free to reply here if you have any questions or think further adjustments are needed.
This is an automated response π€ to assist you in streamlining the contribution process, but rest assured an Ultralytics engineer will review your PR shortly. Thanks for being a part of our open-source community! π
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 73.11%. Comparing base (
5bca934
) to head (21ad03f
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
ultralytics/utils/plotting.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
π Amazing work, @RizwanMunawar and @glenn-jocher! Your collaboration on improving the seg_bbox
function is truly appreciated. π
"In the middle of every difficulty lies opportunity." β Albert Einstein. By carefully optimizing even the smallest details, such as label handling here, you're turning opportunities for improvement into meaningful contributions that enhance the lives of our users. π‘
Thank you for your thoughtful updates and dedication to clean, efficient code. Your effort doesn't just improve performanceβit inspires excellence. Keep shining! β¨
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Improved the
seg_bbox
function in plotting utilities for better handling and rendering of labels. ποΈπ Key Changes
cv2.getTextSize(label)
to execute only when a label is provided.π― Purpose & Impact