search

umanwizard / libeot

Library for parsing Embedded OpenType files (Microsoft embedded font "standard"), and converting them to other formats
Other
14 stars 6 forks source link

Add numInstr bytes for Composite glyph with WE_HAVE_INSTRUCTIONS flag #8

Closed anhngduc closed 1 month ago

anhngduc commented 2 months ago

When flags & WE_HAVE_INSTRUCTIONS then it will follow by uint16 numInstr uint8 instr[numInstr] Ref: https://learn.microsoft.com/en-us/typography/opentype/spec/glyf

umanwizard commented 2 months ago

Thanks, do you have an example of a .eot that fails to be decoded before this change?

anhngduc commented 2 months ago

Hi, I will check how to share the file. Target font is Windows 10. "Calibri Bold Italic" font that is embedded. After converting with original source and testing with ots-sanitize. The ots-sanitize shows an error like this "WARNING: glyf: Bytecode length is bigger than maxp.maxsizeofInstructions %d"

umanwizard commented 1 month ago

You can e-mail the eot to me: brennan@umanwizard.com

anhngduc commented 1 month ago

Hello, how was it?

umanwizard commented 1 month ago

Hi @anhngduc , I did receive your e-mail, but I've been too busy to look at this. I'll look/test it this weekend and merge it if it looks okay.

umanwizard commented 1 month ago

Hi @anhngduc

The first commit looks good.

But it seems you have several other commits with different fixes on the same branch. Can you open those as separate PRs and keep this branch to the WE_HAVE_INSTRUCTIONS issue?

anhngduc commented 1 month ago

Done.