umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.36k stars 2.64k forks source link

Umbraco 14 - ModelsBuilder generates integer label as a string in the model #16613

Open jovanzlatanovic opened 1 week ago

jovanzlatanovic commented 1 week ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0

Bug summary

I have a composition which contains a label with a value type set as integer. Upon generating models after upgrade, the .generated.cs file changes the value type to string.

Specifics

Upon generating models with ModelsBuilder the models which inherit a composition that contains a Label (integer) field, the generated values are no longer of type integer but of string.

image

image

Steps to reproduce

  1. Create a composition containing a Label (integer) field, and create a document type which inherits the composition.
  2. Generate models using ModelsBuilder (SourceCodeManual)

Expected result / actual result

Expected: Expecting that the generated model contains an integer property type.

Actual: Generated model property is a string instead.

github-actions[bot] commented 1 week ago

Hi there @jovanzlatanovic!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: