umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.54k stars 2.71k forks source link

UX Media Picker - V8 : auto selection for the uploaded images and then scroll down to them #6844

Closed saifobeidat closed 4 years ago

saifobeidat commented 5 years ago

When uploading images from the device using the media picker, the users might not know if the uploaded images are really uploaded or not, because there was no action happened after uploading the images.

as we can see in the below example, I am uploading some images to my media folder:

MediaPicker

What I think that would be better if applied on the above process:

nul800sebastiaan commented 5 years ago

Thanks, this has been discussed a few times and while we want to do a complete overhaul of how the media picker works in the future, for now it would be a great ideas to revert the sort order and get the newest files on top, so you can actually see them and pick them immediately after upload.

It would also be a good idea to select the uploaded item(s) because clearly you uploaded them to do something with them.

We'd love some help with this if you can!

For reference, we've discussed many other options in a related issue: https://github.com/umbraco/Umbraco-CMS/issues/5260

umbrabot commented 5 years ago

Hi @saifobeidat,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

kjac commented 5 years ago

I'm hosting a hackaton tomorrow; we'll have a look at this one.

kjac commented 5 years ago

Alright so... #6995 fixes this in part. At least it fixes the auto selection part...

I'm reluctant to start sorting the media picker differently. I'm worried it would be a big behavioral change for existing editors?

Also scrolling automatically to the bottom of the media picker might introduce undesired CPU spikes on the server, as the client might start fetching thumbnails for every last image in the picker.

saifobeidat commented 5 years ago

@kjac Thanks for the PR!

As for the sorting, I think users will not even feel any change, imagine it, editors will upload images then the images will appear immediately, they will not scroll down to find the uploaded images because they saw them already.

Even though, I think it will be much clearer than uploading images and don't know where they went?

kjac commented 5 years ago

@saifobeidat I understand your position. I do however believe that we shouldn't just change the sort order after uploads. That kind of magic behavior is bad in my book. The way I see it, if we need to change the sort order we should do it from the very beginning. And that's why I argue the behavioral breaking change for existing editors.

saifobeidat commented 5 years ago

@kjac okay I got your concerns, and yes I think it it makes sense to sort media items (newest to oldest) from the beginning as you said.

nul800sebastiaan commented 5 years ago

@kjac I know it's a big behavioral change but 1000s of editors will sigh in relief in seeing their most recently uploaded media items at the top. We discussed at HQ and agreed that it would make so much more sense than the current sort order!

Besides, it would only be consistent with how the media library orders items by default, makes no sense to have the media picker sort them in the exact opposite order.

kjac commented 5 years ago

Can't argue against the relieved sigh of thousands of editors! I'll get on it 👍

kjac commented 5 years ago

Strike that. Adding sorting to the entity repository is not something you "just do" 😢

saifobeidat commented 5 years ago

Hi @nul800sebastiaan , sorry but could give me an update for the kjac's PR.. when It can be merged?

Samanoova commented 4 years ago

Hi all i also have the same issue ten they closed my issue and tell me to come here and i would remind that we need to solve this in rich text editor too. i hope that if you would to pull a release that will fix this issue.

Samanoova commented 4 years ago

i think that this solution stop working since i upgrade to 8.4

emmaburstow commented 4 years ago

Fixed in #6995 Thanks Kenn!