search

umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.45k stars 2.68k forks source link

Media picker in RTE (Alt tag broken in various ways). Umbraco v7.15.6 #9784

Closed NicolaSA closed 2 years ago

NicolaSA commented 3 years ago

A brief description of the issue goes here:

1) Media picker alt tag field panel is intermittently displayed + entering an alt value corrupts the image as "/umbraco/nothing.jpg"

  1. Are there plans to render the name of an image/file in the /media/ area into the Media picker's Alt field to reduce admin time across Media area + imagery in RTE's etc?

Umbraco version

I am seeing this issue on Umbraco version: 7.15.6

I can reproduce this effect in both Chrome Version 88.0.4324.146 (Official Build) (64-bit), Edge Version 88.0.705.63 (Official build) (64-bit), FireFox Version 85.0 (64-bit)

I can reproduce this in two distinctly difference installations of: 7.15.6 assembly: 1.0.7537.31667 a) Non cloud, RTE independent of Grid. b) Cloud, RTE is within Grid.

Reproduction

Bug summary / Actual result

Key noted issues for media picker's Alt tag field:

  1. If you add an image to an Rich Text Editor (RTE) (using the media picker) and you forget to complete the Alt tag, going back into the image to complete the alt tag field offers mixed results:

1.1) Sometimes the panel for the selected image does not return so you can't get to the alt field to complete it.

Hack: I can fool the system back into showing the panel by adding another random image and then I can see the panel again for my original image... then issue 1.2 below crops up.

The issue is more prominant, if you publish the page and then return to amend the alt field.

1.2) When you see the panel, there's intermittent/permanent image corruption. This leaves the administrator no choice but to not publish the page, abort and retry via going into the RTE < view source option> which is not a solution our clients can accept.

In my screenshot, the corrupted image has occurred as the correct graphic is replaced with incorrect graphic "/umbraco/nothing.jpg".

I checked v8 and this does not happen.

Specifics

Steps to reproduce

umbraco_MediaPicker_Alt_Panel_Display_alt_Field_corruption

Steps to reproduce

See screenshot attached please.

Expected result

Expected result: We're expecting that an Alt tag and panel should always be accessible when you return to a page needing it's alt tag supplied/improved.

We're expecting that when finally being able to see the panel, that entering a value should not corrupt the image.

emma-hq commented 3 years ago

Hi @NicolaSA,

Thanks for reporting this issue! And also thanks for the screenshots. I'll have a go at reproducing and label or comment depending on what I find.

Emma

NicolaSA commented 3 years ago

Awesome. If you cant reproduce, I'd be more than happy to do a zoom screen share. Thanks a mill.

From: emma-hq notifications@github.com Sent: 09 February 2021 16:33 To: umbraco/Umbraco-CMS Umbraco-CMS@noreply.github.com Cc: Nicola Harding Nicola.Harding@nvisage.co.uk; Mention mention@noreply.github.com Subject: Re: [umbraco/Umbraco-CMS] Media picker in RTE (Alt tag broken in various ways). Umbraco v7.15.6 (#9784)

Hi @NicolaSAhttps://github.com/NicolaSA,

Thanks for reporting this issue! And also thanks for the screenshots. I'll have a go at reproducing and label or comment depending on what I find.

Emma

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/umbraco/Umbraco-CMS/issues/9784#issuecomment-775983211, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA76UN7XM2FVECMHOMDN6PTS6FBUBANCNFSM4XK7TWAA.

emma-hq commented 3 years ago

Hey @NicolaSA

This is indeed a bug - I'll label as up-for-grabs and so a friendly community member can pick it up and fix it :)

Emma

umbrabot commented 3 years ago

Hi @NicolaSA,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

NicolaSA commented 3 years ago

Hi Emma, Thanks a mill for the status update, Nix

From: emma-hq notifications@github.com Sent: 02 March 2021 10:12 To: umbraco/Umbraco-CMS Umbraco-CMS@noreply.github.com Cc: Nicola Harding Nicola.Harding@nvisage.co.uk; Mention mention@noreply.github.com Subject: Re: [umbraco/Umbraco-CMS] Media picker in RTE (Alt tag broken in various ways). Umbraco v7.15.6 (#9784)

Hey @NicolaSAhttps://github.com/NicolaSA

This is indeed a bug - I'll label as up-for-grabs and so a friendly community member can pick it up and fix it :)

Emma

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/umbraco/Umbraco-CMS/issues/9784#issuecomment-788709169, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA76UN7QME2QCAGUFDYMYJLTBSMWJANCNFSM4XK7TWAA.

umbrabot commented 2 years ago

Hiya @NicolaSA,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: