search

umbraco / Umbraco.StorageProviders

MIT License
30 stars 22 forks source link

Support for Umbraco 10 #38

Closed ThomasBaek closed 2 years ago

ThomasBaek commented 2 years ago

Currently testing for Umbraco 10 RC, and it seems like we need an update here. Is there anything planned on when to have an update ready?

An unhandled exception occurred while processing the request. MissingMethodException: Method not found: 'System.String SixLabors.ImageSharp.Web.FormatUtilities.GetExtensionFromUri(System.String)'. Umbraco.StorageProviders.AzureBlob.Imaging.AzureBlobFileSystemImageProvider.IsValidRequest(HttpContext context)

ronaldbarendse commented 2 years ago

Version 1 of this package only supports Umbraco 9 and ImageSharp.Web 1 because of the breaking changes introduced in both new major versions (hence the MissingMethodException).

The work required to support Umbraco 10 and ImageSharp.Web 2 had already started in PR https://github.com/umbraco/Umbraco.StorageProviders/pull/36 (I've now updated the title to reflect this) and since this got merged today, expect a 2.0.0-rc1 release to be be available very soon!

alanwthom commented 2 years ago

Hi @ronaldbarendse, I appreicate this is being worked on, but do you have an estimated release date for v2 by any chance? Trying to figure out whether we can start working on the v10 RC or whether we'll have to stick with v9 for just now. Thanks

ronaldbarendse commented 2 years ago

Nightly builds are available on our MyGet feed (including a test release of 2.0.0-rc1) and we expect to publicly release this RC together with Umbraco 10.0.0-rc2.

alanwthom commented 2 years ago

That's super @ronaldbarendse, thanks. I've got that, so will take it for a spin.