Check object structure to guard against global pollution from HTMLElements

umdjs / umd

UMD (Universal Module Definition) patterns for JavaScript modules that work everywhere.

MIT License

7.42k stars 423 forks source link

Closed mikesherov closed 9 years ago

arthurvr commented 9 years ago

I like this. Fixes #35, right?

mikesherov commented 9 years ago

@arthurvr check the full commit message ;-)

arthurvr commented 9 years ago

@mikesherov Whoops :) Yep! :smile:

addyosmani commented 9 years ago

LGTM. Thanks for writing the patch. Will wait for a second LGTM from @jrburke in case he has further comments before landing.

mikesherov commented 9 years ago

Thanks for the review @addyosmani!

jrburke commented 9 years ago

LGTM

mikesherov commented 9 years ago

Thanks @jrburke! Safe to land :-)

addyosmani commented 9 years ago

Landed. Thanks again, Mike!