search

umee-network / umee

A Golang implementation of the Umee network, a decentralized universal capital facility in the Cosmos ecosystem.
Apache License 2.0
224 stars 170 forks source link

fix: get the token price if token is blacklisted also #2615

Closed gsk967 closed 1 month ago

gsk967 commented 1 month ago

We are getting error when fetching the token price of blacklisted token , this pr will fix that , We only removing the asset from leverage token registry if supply is zero

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request focus on the TokenPrice method within the Keeper struct in the oracle.go file. The modification involves the removal of the check for blacklisted tokens, allowing the method to continue processing even if a token is blacklisted. This change alters the control flow, impacting how errors are handled in relation to token pricing without modifying any exported or public entity signatures.

Changes

File Path Change Summary
x/leverage/keeper/oracle.go Removed check for blacklisted tokens in TokenPrice method, altering control flow and error handling.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Keeper
    participant TokenService

    Client->>Keeper: Request Token Price
    Keeper->>TokenService: Fetch Token Price
    TokenService-->>Keeper: Return Token Price
    Keeper-->>Client: Return Token Price

Poem

In the garden where tokens play,
A blacklisted friend can join the fray.
No more checks to hold them back,
Prices flow on a smoother track.
Hops of joy in the code we see,
A brighter path for you and me! 🐇✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between f3d056567cd17bc1ca533f91587be091fe78571a and 2e29fb97bf4621bd7359311c2f635289b23e2be8.
📒 Files selected for processing (1) * x/leverage/keeper/oracle.go (0 hunks)
💤 Files with no reviewable changes (1) * x/leverage/keeper/oracle.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.01%. Comparing base (7f05ad4) to head (2e29fb9). Report is 542 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/umee-network/umee/pull/2615/graphs/tree.svg?width=650&height=150&src=pr&token=26MOHDPL5B&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network)](https://app.codecov.io/gh/umee-network/umee/pull/2615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network) ```diff @@ Coverage Diff @@ ## main #2615 +/- ## =========================================== - Coverage 75.38% 62.01% -13.38% =========================================== Files 100 275 +175 Lines 8025 19629 +11604 =========================================== + Hits 6050 12172 +6122 - Misses 1589 6685 +5096 - Partials 386 772 +386 ``` | [Files with missing lines](https://app.codecov.io/gh/umee-network/umee/pull/2615?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network) | Coverage Δ | | |---|---|---| | [x/leverage/keeper/oracle.go](https://app.codecov.io/gh/umee-network/umee/pull/2615?src=pr&el=tree&filepath=x%2Fleverage%2Fkeeper%2Foracle.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network#diff-eC9sZXZlcmFnZS9rZWVwZXIvb3JhY2xlLmdv) | `59.58% <ø> (-8.25%)` | :arrow_down: | ... and [215 files with indirect coverage changes](https://app.codecov.io/gh/umee-network/umee/pull/2615/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network)