search

umpirsky / Symfony-Upgrade-Fixer

Analyzes your Symfony project and tries to make it compatible with the new version of Symfony framework.
MIT License
275 stars 18 forks source link

Some deprecations getRequest not fixed #33

Closed PatrickLEBRUN closed 7 years ago

PatrickLEBRUN commented 7 years ago

Hello,

I have run Upgrade-Fixer on my projet Symfony 2.8 Some deprecations on getRequest are not fixed. For example, this extract of code is not corrected :

protected function getSortParameters($route) { $sort = $this->getRequest()->get('tri'); $dir = $this->getRequest()->get('ordre'); $uri = $this->getRequest()->getRequestUri(); $posQueryStr = explode('?', $uri);

Do you know why ?

Thanks,

P.LEBRUN

umpirsky commented 7 years ago

This tool just gives you some wind in the back by fixing some deprecations. The rest is up to you.