fix tests on windows, style fixes

unascribed / FlexVer

A SemVer-compatible intuitive comparator for free-form versioning strings as seen in the wild, designed to sort versions like people do.

Creative Commons Zero v1.0 Universal

64 stars 10 forks source link

fix tests on windows, style fixes #14

Closed Moth-Tolias closed 1 year ago

Moth-Tolias commented 1 year ago

[x] I own the full rights to my contribution, and agree to release it under the terms of the Creative Commons Zero Public Domain Dedication

Moth-Tolias commented 1 year ago

wow, that was fast as heck! i didn't even have time to explain the changes.

a question: it seems the unittest utility functions were moved back into a seperate version(unittest) block when you implemented #3. was that intentional?

unascribed commented 1 year ago

I didn't implement it (note the commit authorship), so I don't know. In general the library should be as light as possible, so if that's comparable to it being inside an #ifdef UNITTEST then I believe that's desirable.