uncefact / spec-jsonld

Exposing the UN/CEFACT vocabulary as web semantics
https://service.unece.org/trade/uncefact/vocabulary/uncefact/
13 stars 5 forks source link

void values of uncefact:TDED #38

Closed VladimirAlexiev closed 2 years ago

VladimirAlexiev commented 2 years ago

some uncefact:TDED "." are void (empty) values: skip them.

And what is TDED? use words not abbreviations

nissimsan commented 2 years ago

TDED = Trade Data Element Directory.

... Do we even need TDED in the vocab at all? I don't think we do.

nissimsan commented 2 years ago

@kshychko , please elaborate where this comes from.

cmsdroff commented 2 years ago

Here is the official definition https://unece.org/trade-facilitation-0

UNECE Trade Data Elements Directory (TDED) The standard data elements included in the Directory are intended to facilitate interchange of data in international trade. These standard data elements can be used with any method of data interchange, on paper documents as well as with other means of data communication; they can be selected for transmission one by one, or used within a particular system of interchange rules, e.g. the United Nations syntax rules for Electronic Data Interchange For Administration, Commerce and Transport (UN/EDIFACT) developed within the UNECE and published as International Standard ISO 9735. Sections 1, 2, 3, 4 and 9 of the Directory constitute International Standard ISO 7372.

The UNTDED is updated, based on reviews by the Maintenance Agency, a joint UNECE - ISO body authorized by UN/CEFACT and by the ISO Council, entrusted with its maintenance in order to keep the UNTDED/ISO7372 up to date to meet changes and new requirements in trade.

Website: http://www.unece.org/tradewelcome/un-centre-for-trade-facilitation-and-e-business-uncefact/outputs/standards/untded-iso7372/introducing-untded-iso7372.html

onthebreeze commented 2 years ago

TDED - means "Trade Data Element Directory" - it's the vocabulary that supported the old EDIFACT domain. Not sure how it got into this JSON-LD vocabulary but maybe from EDIFACT code lists which we pulled into this vocabulary but arent in the Core component library?

@kshychko - could you figure out where this came from? then we can answer the question about what to do with it

VladimirAlexiev commented 2 years ago

It's some code on BIEs:

cefact:Exchanged_Document.Acceptance.DateTime uncefact:TDED "2097"

I vote to keep it but rename to lowercase, omit the void values ".", and define it properly:

uncefact:tded a owl:DatatypeProperty;
  rdfs:label "TDED";
  schema:domainIncludes TODO;
  schema:rangeIncludes xsd:string;
  rdfs:comment "Trade Data Elements Directory code";
  skos:scopeNote "4-digit code of the BIE";
  rdfs:seeAlso <http://www.unece.org/tradewelcome/un-centre-for-trade-facilitation-and-e-business-uncefact/outputs/standards/untded-iso7372/introducing-untded-iso7372.html>.
nissimsan commented 2 years ago

Agreement on the call to skip the blanks. We don't have to explicitly capture "there is no TDED mapping for this value".

nissimsan commented 2 years ago

@kshychko , please confirm that this is fixed already?

kshychko commented 2 years ago

TDED property has been renamed to tded and empty ('.') values are ignored.

kshychko commented 2 years ago

As the next step, we can publish EDIFACT codes and link the properties with TDED defined.

nissimsan commented 2 years ago

Done: https://github.com/uncefact/spec-jsonld/pull/112

VladimirAlexiev commented 11 months ago