uncefact / spec-jsonld

Exposing the UN/CEFACT vocabulary as web semantics
https://service.unece.org/trade/uncefact/vocabulary/uncefact/
13 stars 5 forks source link

Document vs Line Structure #44

Closed VladimirAlexiev closed 2 years ago

VladimirAlexiev commented 2 years ago

Document has enough props to describe also "Document Lines", which are document parts:

However, there's no way to express a document hierarchy or parthood:

This leads to confusions such as

uncefact:lineStatusReasonCode rdfs:comment "The code specifying the line status reason for this document line." ; schema:domainIncludes uncefact:Document .

- Wrong domain of `lineTotalBasisAmount`? Where is that "line" mentioned in the description?
  - `Tax` has 51 attributes including `basisAmount` so how can one distinguish between the two?
  - On the other hand its "sibling" prop `lineTotalAmount` has domain `MonetarySummation`
```ttl
uncefact:lineTotalBasisAmount
        rdfs:comment                    "A monetary value used as the line total basis on which this trade related tax, levy or duty is calculated." ;
        schema:domainIncludes           uncefact:Tax ;
nissimsan commented 2 years ago

This does indeed need some investigation. To my knowledge this doesn't actually like properties to standard documents. Unless I am overlooking something, I'm inclined to get rid of these properties.

Fak3 commented 2 years ago

I was puzzled by the usefulness and semantics of those properties when I tried to model VC1 Wine import cert.