search

uncefact / spec-jsonld

Exposing the UN/CEFACT vocabulary as web semantics
https://service.unece.org/trade/uncefact/vocabulary/uncefact/
13 stars 5 forks source link

fix: doublons in property names #90

Closed kshychko closed 2 years ago

kshychko commented 2 years ago
Closes #51 Below are the results of property renaming when the implemented NDR rules are applied: old name new name comment
automaticDataCaptureMethodAutomaticDataCaptureMethodTypeCode automaticDataCaptureMethodTypeCode
documentLineDocumentLineStatusCode documentLineStatusCode
dueDateDateTime dueDateTime (already exists in the old set)
locationFunctionFunctionTypeCode locationFunctionTypeCode (already exists in the old set)
logisticsSealSealingPartyRoleCode logisticsSealingPartyRoleCode
referenceReferenceTypeCode referenceTypeCode
transportServiceConditionConditionTypeCode transportServiceConditionTypeCode
kshychko commented 2 years ago

@nissimsan, an additional fix is needed I converted the PR to drafted, will push an update soon

nissimsan commented 2 years ago

@kshychko, excellent.

The process we're aiming for is to merge when we're all together on the calls. That allows us to all keep track of how things are evolving - and you to shine in all the praise you deserve from the team! :) So in the future, please hold of with the merge, and just line up good PRs.