search

uncovery / uncovery_me

Full source of the uncovery.me minecraft server
GNU General Public License v3.0
12 stars 3 forks source link

Revamp item icons #292

Closed uncovery closed 4 years ago

uncovery commented 7 years ago

We currently store item icons by using data in the idemdata array (such as here). We re-download this data every 24 hours and store it on our server.

Instead, we should be using the one-file data here and store the item position in the sprite in the data file for flexible use.

This also goes for the potions and banner patterns etc.

This is both a code improvement (for items where the icon currently exists) as well as a bug fix for items where the icon is currently broken (lingering potions etc)

uncovery commented 6 years ago

We will move to use these two datasets once 1.13 is live:

https://github.com/rom1504/minecraft-assets https://github.com/PrismarineJS/minecraft-data

uncovery commented 4 years ago

This is basically done, except that the data is not always up to date.

uncovery commented 4 years ago

The only source for the full block icons is on the wiki, not in the minecraft jar. Ideally, this function would be maintained in the minecraft-wiki-extractor: https://github.com/PrismarineJS/minecraft-wiki-extractor/issues/29#issuecomment-629038677

uncovery commented 4 years ago

This is basically done, except that the data is not always up to date.

I have now written thsi code so that at least we can get the latest version easier: https://github.com/uncovery/minecraft_datascript

The wiki issue is basically solved here: https://github.com/uncovery/uncovery_me/blob/master/includes/wiki_data.inc.php#L3 until it will be integrated here: PrismarineJS/minecraft-wiki-extractor#29 (comment)

I will consider this as solved, as there might be new issues coming up with future versions anyhow. We can now automatically extract 1.15.2 data in full.