search

ungoogled-software / ungoogled-chromium-debian

Debian, Ubuntu, and others packaging for ungoogled-chromium
386 stars 49 forks source link

[debian_buster] Update to 80.0.3987.122 #79

Closed ghost closed 4 years ago

ghost commented 4 years ago

This still needs some test builds to verify the rest but the patch validator should be happy.

ghost commented 4 years ago

Still no successful build but I am getting closer with each fix.

ghost commented 4 years ago

Ugh. I give up. I can't resolve a problem with the re2 library. The one shipped with Debian Buster is too old due to changes in the API that Chromium now relies on and I cannot get it to build if I try to use the included re2 library. I will leave this open for someone else to try to resolve the problem.

ghost commented 4 years ago

@tangalbert919 Any ideas if you could take a look at upgrading to 80? I'm unable to make further progress.

tangalbert919 commented 4 years ago

I'll take a look, and send a PR to your fork when I finish.

ghost commented 4 years ago

Sure. I'll also bump the version since there's now an update available.

ghost commented 4 years ago

Done.

ghost commented 4 years ago

I forgot to include a simple patch for a compile error I found earlier that results from a new upstream patch from Debian. It is now.

ghost commented 4 years ago

I had the idea of doing a hack to fix the GetRE2 visibility though I'm not happy with this method it does seem to work. Essentially it would hack the private API into the public space for that file so it can see it and use it. But I don't know what other problems that could create. This is the patch I came up with:

http://dpaste.com/0YK72WZ

ghost commented 4 years ago

Ok so my hack allowed it to compile but I still need a final solution to the RE2 problem. Hm.

Eloston commented 4 years ago

@braewoods I haven't looked into the details yet, but why can't we just use the bundled version of re2 for now? See https://github.com/ungoogled-software/ungoogled-chromium-debian#notes-on-updating-older-branches

ghost commented 4 years ago

@Eloston it now builds against debian 10. All that's left is to test the resulting build. It should be ready for merging but let me know if there's anything else blocking the merge.

ghost commented 4 years ago

Please wait a bit longer to merge. I'm testing an addition to the exclusions list that will hopefully fix the check for prebuilt binary files.

ghost commented 4 years ago

Done. I'm ready to be merged unless there's something I missed.