search

ungoogled-software / ungoogled-chromium-debian

Debian, Ubuntu, and others packaging for ungoogled-chromium
386 stars 49 forks source link

[debian_sid] Update to 80.0.3987.149-2 #98

Closed ghost closed 4 years ago

ghost commented 4 years ago

Doing a test build first. Failed to install dependencies so going to try updating to Clang 10.

ghost commented 4 years ago

@Eloston I'm getting a fair number of new warnings from Clang 10, all from a single warning type. Should we try to patch them at all? They look like this: ../../third_party/pdfium/core/fpdfapi/page/cpdf_contentmarks.cpp:112:19: warning: loop variable 'pMark' of type 'const fxcrt::RetainPtr' creates a copy from type 'cons t fxcrt::RetainPtr' [-Wrange-loop-construct] ../../third_party/pdfium/core/fpdfapi/page/cpdf_contentmarks.cpp:112:8: note: use reference type 'const fxcrt::RetainPtr &' to prevent copying

ghost commented 4 years ago

I'm thinking of attempting to create a patch for this. I don't think Debian upstream will patch this for awhile since Clang 10 is so new.

ghost commented 4 years ago

Wow. A lot of warnings spam. I am going to need to disable a few and try a rebuild out.

ghost commented 4 years ago

I think I found a patch that can be removed. It sets a flag for Clang that is no longer available or was only available for GCC. I'll retest with a new build.

ghost commented 4 years ago

@Eloston I think it's ready for merging. I decided to just disable the new warnings for now as I think Debian or Chromium will eventually patch them properly.