unic / estatico

[DEPRECATED] Estático – Static site generator for frontend unicorns
Other
121 stars 18 forks source link

JS initialization broken #35

Closed swey closed 7 years ago

swey commented 7 years ago

The data-init is using the class name (not the lowercase name/key): https://github.com/unic/estatico/blob/develop/source/modules/.scaffold/scaffold.hbs#L1 data-init="{{className}}"

but the gulp task is using the lowercase name/key to add modules to the EstaticoApp: https://github.com/unic/estatico/blob/develop/gulp/scaffold/default.js#L51 insertionTemplate: 'this.modules.{{keyName}} = {{className}};\n ',

(Wrote it before in the slack channel and in my PRs, but for the sake of completeness I created that issue.)