search

unicurses / unicurses

Github fork for unicurses
GNU General Public License v3.0
152 stars 20 forks source link

pdcurses.dll fails locate in Win10 python 3.8 site-packages #11

Closed pjfarleyiii closed 3 years ago

pjfarleyiii commented 4 years ago

The exception code for properly locating the pdcurses.dll in the unicurses.py directory can be fixed to support this failure.

Attaching my diff -u patch (I hope this works).

HTH

Peter

unicurses.patch.txt

chtenb commented 4 years ago

Could you open a pull request instead of sending a patch?

pjfarleyiii commented 4 years ago

Sorry I did not reply back in July, I got very busy with RL work and am just now coming back to this issue and the other one I raised about the access violation from a calling python script.

I would gladly open a pull request if I knew how. If you can give me a step-by-step (for a Windows host machine) I would appreciate it.

I do have git for Windows installed as well as MS Virtual Studio 2019 if either of those tools makes it easier to do.

If you know how to set up pdcurses in VS2019 so it can be debugged from a calling python script using the Unicurses wrapper I could debug some of the call-DLL-from-python issues too.

Peter

chtenb commented 4 years ago

I can't really help you with debugging pdcurses unfortunately. I haven't used it in years, and never really used it on windows.

I would gladly open a pull request if I knew how. If you can give me a step-by-step (for a Windows host machine) I would appreciate it.

Fork this repo, install git, clone your fork, make and push changes, open pull request.

pjfarleyiii commented 4 years ago

OK, thanks for the git advice. I will try to do it that way.

Peter