unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

guide info is gone after normalizing #68

Closed typemytype closed 4 years ago

typemytype commented 4 years ago

@madig

could you revert the change back: its wrong to remove the x data if this is set.

and its also wrong according the spec http://unifiedfontobject.org/versions/ufo3/glyphs/glif/#guideline

https://github.com/unified-font-object/ufoNormalizer/commit/59197896539394079152899d49b2048ae2dce7e4

frankrolf commented 4 years ago

I am constantly running into this. Please revert, @madig .

benkiel commented 4 years ago

@frankrolf This was reverted, as of version 0.4.1. Are you still having issues?

frankrolf commented 4 years ago

Odd. I saw some flipped font guidelines yesterday, and checked that I am using the latest version. Let me double-check what’s going on.

frankrolf commented 4 years ago

Okay, strange. I tried to reproduce the scenario exactly, and everything works as expected (with both local and global guidelines). I swear I wasn’t just seeing things – but can’t find the issue again. I will close this for now, and reopen if I find the problem again.