search

unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

Fix version import #81

Closed josh-hadley closed 3 years ago

josh-hadley commented 3 years ago

See https://github.com/unified-font-object/ufoNormalizer/pull/79#issuecomment-750455920

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 87.543% when pulling d40c753247565ea6c4ef8fee4f6bf8a3a726d0f3 on jh-fix-version-bug into 89e6d4dfbd55f1834aee6fd537c6a4145b792dc6 on master.

anthrotype commented 3 years ago

sorry I missed this last time! i suggest adding a little test as well

josh-hadley commented 3 years ago

sorry I missed this last time!

Same 🤭

i suggest adding a little test as well

I'll add this. I think just a simple test that __version__ is not "unknown" should suffice, as I think that should only happen in unusual cases like someone extracted the uninstalled source outside of scm and ran the tests. Not impossible, but unlikely in normal use. @anthrotype what do you think?

anthrotype commented 3 years ago

sounds good

benkiel commented 3 years ago

Thanks!