unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

Guidelines at x=0 or y=0 are discarded #82

Closed madig closed 3 years ago

madig commented 3 years ago

Is this intentional?

belluzj commented 3 years ago

Sorry, what I wrote there should probably be instead:

https://github.com/unified-font-object/ufoNormalizer/blob/783ec1479ed35f26a9992cb18927f1902207b0af/src/ufonormalizer/__init__.py#L524-L530

    # The spec was ambiguous about y=0 or x=0, so don't raise an error here,
    # instead, <x=300 y=0> or <x=0 y=300> are allowed, and the 0 becomes None.
    if angle is None:
        if x == 0 and y is not None:
            x = None
        if y == 0 and x is not None:
            y = None
benkiel commented 3 years ago

@anthrotype @belluzj @madig thanks for this fixup — and for cutting a release!