search

unikent / programmes-plant

A comprehensive solution for the management of university programmes, that produces an XCRI feed.
Other
7 stars 4 forks source link

Test Suite Broken #45

Closed conatus closed 11 years ago

conatus commented 11 years ago

The test suite is currently quite broken.

There were 52 errors:

1) TestAwards_Controller
Laravel\Database\Exception: SQLSTATE[3D000]: Invalid catalog name: 1046 No database selected

SQL: CREATE TABLE `laravel_migrations` (`bundle` VARCHAR(50) NOT NULL, `name` VARCHAR(200) NOT NULL, `batch` INT NOT NULL)

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/controllers/award.test.php:12

2) TestAwards_Controller
Laravel\Database\Exception: SQLSTATE[3D000]: Invalid catalog name: 1046 No database selected

SQL: CREATE TABLE `laravel_migrations` (`bundle` VARCHAR(50) NOT NULL, `name` VARCHAR(200) NOT NULL, `batch` INT NOT NULL)

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/controllers/award.test.php:12

3) TestAwards_Controller
Laravel\Database\Exception: SQLSTATE[3D000]: Invalid catalog name: 1046 No database selected

SQL: CREATE TABLE `laravel_migrations` (`bundle` VARCHAR(50) NOT NULL, `name` VARCHAR(200) NOT NULL, `batch` INT NOT NULL)

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/controllers/award.test.php:12

4) TestCampuses_Controller
Laravel\Database\Exception: SQLSTATE[3D000]: Invalid catalog name: 1046 No database selected

SQL: CREATE TABLE `laravel_migrations` (`bundle` VARCHAR(50) NOT NULL, `name` VARCHAR(200) NOT NULL, `batch` INT NOT NULL)

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/controllers/campuses.test.php:12

5) TestProgrammes_Controller::testRemainOnTheSamePageWhenSavingProgrammes
Laravel\Database\Exception: SQLSTATE[3D000]: Invalid catalog name: 1046 No database selected

SQL: CREATE TABLE `laravel_migrations` (`bundle` VARCHAR(50) NOT NULL, `name` VARCHAR(200) NOT NULL, `batch` INT NOT NULL)

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/lib/ControllerTestCase.php:21

and so on, for every test in the suite, at least on my home machine.

What is breaking is the migrations setting up the database appear to no longer be functioning, as something weird had been introduced.

The brokenness seems to occur between f708762 (broken) and 6639db0 (okay).

Would like to get this fixed!

conatus commented 11 years ago

Removing *.local from paths.php gets us a little further.

It blazes through the migrations (see what php artisan test does on master) then starts spitting out errors.

There were 52 errors:

1) TestAwards_Controller
Laravel\Database\Exception: SQLSTATE[23000]: Integrity constraint violation: 19 PRIMARY KEY must be unique

SQL: INSERT INTO "programmes_revisions" ("year", "created_by", "programme_title_1", "slug_2", "award_3", "awarding_institute_or_body_4", "honours_type_5", "administrative_school_6", "additional_school_7", "subject_area_1_8", "subject_area_2_9", "ucas_code_10", "location_11", "mode_of_study_12", "attendance_mode_13", "attendance_pattern_14", "duration_15", "accredited_by_16", "programme_type_17", "total_kent_credits_awarded_on_completion_18", "total_ects_credits_awarded_on_completion_19", "programme_abstract_20", "programme_overview_text_21", "foundation_year_22", "year_in_industry_23", "year_abroad_24", "teaching_and_assessment_25", "programme_aims_26", "learning_outcomes_27", "careers_overview_28", "professional_recognition_29", "entry_profile_30", "homeeu_students_intro_text_31", "a_level_32", "cgse_33", "cambridge_preu_34", "international_baccalaureate_35", "access_to_he_diploma_36", "btec_level_5_hnd_37", "btec_level_3_extended_diploma_formerly_btec_national_diploma_38", "scottish_qualifications_39", "irish_leaving_certificate_40", "international_students_intro_textarea_41", "kent_international_foundation_programme_42", "english_language_requirements_43", "entry_requirements_overriding_text_44", "tuition_fees_45", "subject_leaflet_46", "subject_leaflet_2_47", "student_profile_48", "student_profile_2_49", "kiscourseid_50", "kistype_51", "updated_at", "created_at", "id", "programme_id", "status") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)

Bindings: array (
  0 => '2012',
  1 => 'at369',
  2 => 'Accounting and Finance with a Year in Industry',
  3 => 'accounting-and-finance-with-a-year-in-industry',
  4 => '1',
  5 => 'University of Kent',
  6 => 'Single honours',
  7 => '1',
  8 => '1',
  9 => '1',
  10 => '1',
  11 => '1234',
  12 => '1',
  13 => 'Full-time only',
  14 => 'false',
  15 => 'false',
  16 => '',
  17 => '',
  18 => '',
  19 => '',
  20 => '',
  21 => '',
  22 => '',
  23 => '',
  24 => '',
  25 => '',
  26 => '',
  27 => '',
  28 => '',
  29 => '',
  30 => '',
  31 => '',
  32 => '',
  33 => '',
  34 => '',
  35 => '',
  36 => '',
  37 => '',
  38 => '',
  39 => '',
  40 => '',
  41 => '',
  42 => '',
  43 => '',
  44 => '',
  45 => '',
  46 => '',
  47 => '',
  48 => '',
  49 => '',
  50 => '',
  51 => '',
  52 => '',
  53 => '2012-11-29 22:14:26',
  54 => '2012-11-29 22:14:26',
  55 => 1,
  56 => 2,
  57 => 'selected',
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/query.php:823
/Users/alex/Code/programmes-plant/application/models/revisionable.php:114
/Users/alex/Code/programmes-plant/application/migrations/2012_11_28_213635_add_programme_data.php:112
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:85
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:52
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:32
/Users/alex/Code/programmes-plant/application/tests/controllers/award.test.php:12

2) TestAwards_Controller
Laravel\Database\Exception: SQLSTATE[23000]: Integrity constraint violation: 19 PRIMARY KEY must be unique

SQL: INSERT INTO "programmes_revisions" ("year", "created_by", "programme_title_1", "slug_2", "award_3", "awarding_institute_or_body_4", "honours_type_5", "administrative_school_6", "additional_school_7", "subject_area_1_8", "subject_area_2_9", "ucas_code_10", "location_11", "mode_of_study_12", "attendance_mode_13", "attendance_pattern_14", "duration_15", "accredited_by_16", "programme_type_17", "total_kent_credits_awarded_on_completion_18", "total_ects_credits_awarded_on_completion_19", "programme_abstract_20", "programme_overview_text_21", "foundation_year_22", "year_in_industry_23", "year_abroad_24", "teaching_and_assessment_25", "programme_aims_26", "learning_outcomes_27", "careers_overview_28", "professional_recognition_29", "entry_profile_30", "homeeu_students_intro_text_31", "a_level_32", "cgse_33", "cambridge_preu_34", "international_baccalaureate_35", "access_to_he_diploma_36", "btec_level_5_hnd_37", "btec_level_3_extended_diploma_formerly_btec_national_diploma_38", "scottish_qualifications_39", "irish_leaving_certificate_40", "international_students_intro_textarea_41", "kent_international_foundation_programme_42", "english_language_requirements_43", "entry_requirements_overriding_text_44", "tuition_fees_45", "subject_leaflet_46", "subject_leaflet_2_47", "student_profile_48", "student_profile_2_49", "kiscourseid_50", "kistype_51", "updated_at", "created_at", "id", "programme_id", "status") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)

Bindings: array (
  0 => '2012',
  1 => 'at369',
  2 => 'Accounting and Finance with a Year in Industry',
  3 => 'accounting-and-finance-with-a-year-in-industry',
  4 => '1',
  5 => 'University of Kent',
  6 => 'Single honours',
  7 => '1',
  8 => '1',
  9 => '1',
  10 => '1',
  11 => '1234',
  12 => '1',
  13 => 'Full-time only',
  14 => 'false',
  15 => 'false',
  16 => '',
  17 => '',
  18 => '',
  19 => '',
  20 => '',
  21 => '',
  22 => '',
  23 => '',
  24 => '',
  25 => '',
  26 => '',
  27 => '',
  28 => '',
  29 => '',
  30 => '',
  31 => '',
  32 => '',
  33 => '',
  34 => '',
  35 => '',
  36 => '',
  37 => '',
  38 => '',
  39 => '',
  40 => '',
  41 => '',
  42 => '',
  43 => '',
  44 => '',
  45 => '',
  46 => '',
  47 => '',
  48 => '',
  49 => '',
  50 => '',
  51 => '',
  52 => '',
  53 => '2012-11-29 22:14:26',
  54 => '2012-11-29 22:14:26',
  55 => 1,
  56 => 2,
  57 => 'selected',
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/query.php:823
/Users/alex/Code/programmes-plant/application/models/revisionable.php:114
/Users/alex/Code/programmes-plant/application/migrations/2012_11_28_213635_add_programme_data.php:112
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:85
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:52
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:32
/Users/alex/Code/programmes-plant/application/tests/controllers/award.test.php:12

3) TestAwards_Controller
Laravel\Database\Exception: SQLSTATE[23000]: Integrity constraint violation: 19 PRIMARY KEY must be unique

SQL: INSERT INTO "programmes_revisions" ("year", "created_by", "programme_title_1", "slug_2", "award_3", "awarding_institute_or_body_4", "honours_type_5", "administrative_school_6", "additional_school_7", "subject_area_1_8", "subject_area_2_9", "ucas_code_10", "location_11", "mode_of_study_12", "attendance_mode_13", "attendance_pattern_14", "duration_15", "accredited_by_16", "programme_type_17", "total_kent_credits_awarded_on_completion_18", "total_ects_credits_awarded_on_completion_19", "programme_abstract_20", "programme_overview_text_21", "foundation_year_22", "year_in_industry_23", "year_abroad_24", "teaching_and_assessment_25", "programme_aims_26", "learning_outcomes_27", "careers_overview_28", "professional_recognition_29", "entry_profile_30", "homeeu_students_intro_text_31", "a_level_32", "cgse_33", "cambridge_preu_34", "international_baccalaureate_35", "access_to_he_diploma_36", "btec_level_5_hnd_37", "btec_level_3_extended_diploma_formerly_btec_national_diploma_38", "scottish_qualifications_39", "irish_leaving_certificate_40", "international_students_intro_textarea_41", "kent_international_foundation_programme_42", "english_language_requirements_43", "entry_requirements_overriding_text_44", "tuition_fees_45", "subject_leaflet_46", "subject_leaflet_2_47", "student_profile_48", "student_profile_2_49", "kiscourseid_50", "kistype_51", "updated_at", "created_at", "id", "programme_id", "status") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)

Bindings: array (
  0 => '2012',
  1 => 'at369',
  2 => 'Accounting and Finance with a Year in Industry',
  3 => 'accounting-and-finance-with-a-year-in-industry',
  4 => '1',
  5 => 'University of Kent',
  6 => 'Single honours',
  7 => '1',
  8 => '1',
  9 => '1',
  10 => '1',
  11 => '1234',
  12 => '1',
  13 => 'Full-time only',
  14 => 'false',
  15 => 'false',
  16 => '',
  17 => '',
  18 => '',
  19 => '',
  20 => '',
  21 => '',
  22 => '',
  23 => '',
  24 => '',
  25 => '',
  26 => '',
  27 => '',
  28 => '',
  29 => '',
  30 => '',
  31 => '',
  32 => '',
  33 => '',
  34 => '',
  35 => '',
  36 => '',
  37 => '',
  38 => '',
  39 => '',
  40 => '',
  41 => '',
  42 => '',
  43 => '',
  44 => '',
  45 => '',
  46 => '',
  47 => '',
  48 => '',
  49 => '',
  50 => '',
  51 => '',
  52 => '',
  53 => '2012-11-29 22:14:26',
  54 => '2012-11-29 22:14:26',
  55 => 1,
  56 => 2,
  57 => 'selected',
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/query.php:823
/Users/alex/Code/programmes-plant/application/models/revisionable.php:114
/Users/alex/Code/programmes-plant/application/migrations/2012_11_28_213635_add_programme_data.php:112
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:85
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:52
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:32
/Users/alex/Code/programmes-plant/application/tests/controllers/award.test.php:12

4) TestCampuses_Controller
Laravel\Database\Exception: SQLSTATE[HY000]: General error: 1 table "laravel_migrations" already exists

SQL: CREATE TABLE "laravel_migrations" ("bundle" VARCHAR NULL, "name" VARCHAR NULL, "batch" INTEGER NULL, PRIMARY KEY ("bundle", "name"))

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/controllers/campuses.test.php:12

5) TestProgrammes_Controller::testRemainOnTheSamePageWhenSavingProgrammes
Laravel\Database\Exception: SQLSTATE[HY000]: General error: 1 table "laravel_migrations" already exists

SQL: CREATE TABLE "laravel_migrations" ("bundle" VARCHAR NULL, "name" VARCHAR NULL, "batch" INTEGER NULL, PRIMARY KEY ("bundle", "name"))

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/lib/ControllerTestCase.php:21

6) TestAward
Laravel\Database\Exception: SQLSTATE[HY000]: General error: 1 table "laravel_migrations" already exists

SQL: CREATE TABLE "laravel_migrations" ("bundle" VARCHAR NULL, "name" VARCHAR NULL, "batch" INTEGER NULL, PRIMARY KEY ("bundle", "name"))

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/models/award.test.php:11

7) TestCampus
Laravel\Database\Exception: SQLSTATE[HY000]: General error: 1 table "laravel_migrations" already exists

SQL: CREATE TABLE "laravel_migrations" ("bundle" VARCHAR NULL, "name" VARCHAR NULL, "batch" INTEGER NULL, PRIMARY KEY ("bundle", "name"))

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/models/campus.test.php:13

8) TestCampus
Laravel\Database\Exception: SQLSTATE[HY000]: General error: 1 table "laravel_migrations" already exists

SQL: CREATE TABLE "laravel_migrations" ("bundle" VARCHAR NULL, "name" VARCHAR NULL, "batch" INTEGER NULL, PRIMARY KEY ("bundle", "name"))

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/models/campus.test.php:13

9) TestCampus
Laravel\Database\Exception: SQLSTATE[HY000]: General error: 1 table "laravel_migrations" already exists

SQL: CREATE TABLE "laravel_migrations" ("bundle" VARCHAR NULL, "name" VARCHAR NULL, "batch" INTEGER NULL, PRIMARY KEY ("bundle", "name"))

Bindings: array (
)

/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:263
/Users/alex/Code/programmes-plant/laravel/laravel/database/connection.php:183
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:114
/Users/alex/Code/programmes-plant/laravel/laravel/database/schema.php:19
/Users/alex/Code/programmes-plant/laravel/laravel/cli/tasks/migrate/migrator.php:187
/Users/alex/Code/programmes-plant/laravel/laravel/cli/command.php:49
/Users/alex/Code/programmes-plant/application/libraries/tests/helper.php:22
/Users/alex/Code/programmes-plant/application/tests/models/campus.test.php:13

and so on, until every test is failed.

I suspect it's something wrong in https://github.com/conatus/programmes-plant/blob/master/application/libraries/tests/helper.php whereby the migrations are being re-run every time instead of once. If you notice there there is a check to see if the migrations are run, then something to prevent them being run if this has already happened. The above General error: 1 table "laravel_migrations" already exists seems to the outcome of this.

conatus commented 11 years ago

Ahhh. So the first two failures seem to be something to do with the database as well, as they too occur when it is migrated...

conatus commented 11 years ago

If you notice the complete pattern is:

Notice: Trying to get property of non-object in /Users/alex/Code/programmes-plant/laravel/laravel/database/query.php on line 677
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE.......

Time: 1 second, Memory: 11.25Mb

So some tests do pass.

Notice: Trying to get property of non-object in /Users/alex/Code/programmes-plant/laravel/laravel/database/query.php on line 677
not ok 0 - Error: TestAwards_Controller
not ok 0 - Error: TestAwards_Controller
not ok 0 - Error: TestAwards_Controller
not ok 0 - Error: TestCampuses_Controller
not ok 1 - Error: TestProgrammes_Controller::testRemainOnTheSamePageWhenSavingProgrammes
not ok 1 - Error: TestAward
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestCampus
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestLeaflet
not ok 1 - Error: TestProgrammeField
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
not ok 1 - Error: TestSchool
ok 2 - TestSimpleData::testall_as_listReturnsArray
ok 3 - TestSimpleData::testall_as_listReturnsData
ok 4 - TestSimpleData::testis_validRulesAreAddedSuccessfully
ok 5 - TestSimpleData::testis_validRulesAreOverwrittenSuccessfully
ok 6 - TestSimpleData::testis_validReturnsTrueWhenValidationSucceeds
ok 7 - TestSimpleData::testis_validReturnsFalseWhenValidationFails
ok 8 - TestSimpleData::testpopulate_from_inputSetsModelFromInput
ok 9 - TestSimpleData::testpopulate_from_inputThrowsExceptionThereIsNoValidation

Is there a pattern here?

gnozu commented 11 years ago

I've noticed on my installation that php artisan test now tries to run config/local/database.php rather than the test one. Mind you it still breaks if I switch to sqlite.

gnozu commented 11 years ago

But if I switch to an older branch more or less at random (eg I tried 1401-id-multi-select) it reads the right config and all works fine.

conatus commented 11 years ago

I changed back to the version from master - https://gist.github.com/4172704

Which caused me to begin to get the second version of the long stream of errors above. It is doing the migrations once. But then not "knowing" that it shouldn't do them again so failing. And I don't know what broke to stop this from happening...

conatus commented 11 years ago

Precisely! As I said above moving back between commits - f708762 (is broken) and 6639db0 (is okay). So it must have been introduced in f708762.

gnozu commented 11 years ago

Ah you know what it is... it's that stupid bit of code in revisionable.php that mysql can cope with but not sqlite. I cut it out, but it obviously crept back in in that mega-mega-merge from a week ago.

conatus commented 11 years ago

A ha! Maybe. If that solved the problem I can sleep soundly!

On 29 November 2012 23:58, gnozu notifications@github.com wrote:

Ah you know what it is... it's that stupid bit of code in revisionable.php that mysql can cope with but not sqlite. I cut it out, but it obviously crept back in in that mega-mega-merge from a week ago.

— Reply to this email directly or view it on GitHubhttps://github.com/conatus/programmes-plant/issues/45#issuecomment-10872456.

Records On Ribs - a record label that releases all its music for free download under a Creative Commons license http://recordsonribs.com

gnozu commented 11 years ago

It might well be the two bits in revisionable with:

        $last = $query->lists('id');
        $last = end($last);
        $revision_attributes = $this->attributes;
        $revision_attributes['id'] = $last + 1;

I still don't understand why my test environment isn't working properly, but that's a separate thing

gnozu commented 11 years ago

I can go back through git time on Monday and work out what I did to fix it. Sleep well!

conatus commented 11 years ago

Likely. But the test environment was working for me, on two different machines with different setups until today. :(

What I'll likely do it merge the broken commit into the working one, so I can, file by file, add it back in until it breaks, unless anyone can solve this while I'm away.

On 30 November 2012 00:05, gnozu notifications@github.com wrote:

It might well be the two bits in revisionable with:

    $last = $query->lists('id');
    $last = end($last);
    $revision_attributes = $this->attributes;
    $revision_attributes['id'] = $last + 1;

I still don't understand why my test environment isn't working properly, but that's a separate thing

— Reply to this email directly or view it on GitHubhttps://github.com/conatus/programmes-plant/issues/45#issuecomment-10872667.

Records On Ribs - a record label that releases all its music for free download under a Creative Commons license http://recordsonribs.com

conatus commented 11 years ago

Hmmm, just deleted your comment by mistake. 

ok well don't get too bogged down. When I make a quick hack to that bit of code I only get 2 errors and 1 failure.      And I guess the 2 errors are my ldap setup and some other related auto-increment type issue with sqlite. Not sure why I get the failure. 
So it looks like it may just be something in your setup?

Yup, it may well be my machine, but the fact that test do work further back in the tree and break at a specific point tells me that something has been introduced which breaks them. Or maybe you are seeing genuine failures and my environment is messed up! That failure is likely a test actually failing...

Frustrating. No tests when you are used to that green light makes you feel like not having a safety net!

conatus commented 11 years ago

The test are now working.